[bitnami/moodle] Handle --prefix (table prefix) being overridden via MOODLE_INSTALL_EXTRA_ARGS #51278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TRA_ARGS At the moment libmoodle.sh assumes a table prefix of the default mdl_ . When someone overrides this with the --prefix=xxx, then there are errors with the sql statements in libmoodle.sh that reference tables with mdl_.... Signed-off-by: Brooke Hedrick <brooke.t.hedrick@gmail.com>
[bitnami/moodle] Handle --prefix (table prefix) being overridden via MOODLE_INSTALL_EX…
Part 2 of 2 for --prefix support. Using the new mdl_prefix variable. Signed-off-by: Brooke Hedrick <brooke.t.hedrick@gmail.com>
|
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
mdhont
suggested changes
Oct 26, 2023
…dle.sh Co-authored-by: Michiel <mdhont79@gmail.com> Signed-off-by: Brooke Hedrick <brooke.t.hedrick@gmail.com>
simplified version Signed-off-by: Brooke Hedrick <brooke.t.hedrick@gmail.com>
|
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
|
Hello, Is anything else needed from me? I have made the requested changes to the pull request. -Brooke |
mdhont
approved these changes
Dec 4, 2023
christian-scheible
pushed a commit
to christian-scheible/containers
that referenced
this pull request
Dec 7, 2023
…MOODLE_INSTALL_EXTRA_ARGS (bitnami#51278) * Handle --prefix (table prefix) being overridden via MOODLE_INSTALL_EXTRA_ARGS At the moment libmoodle.sh assumes a table prefix of the default mdl_ . When someone overrides this with the --prefix=xxx, then there are errors with the sql statements in libmoodle.sh that reference tables with mdl_.... Signed-off-by: Brooke Hedrick <brooke.t.hedrick@gmail.com> * Update libmoodle.sh Part 2 of 2 for --prefix support. Using the new mdl_prefix variable. Signed-off-by: Brooke Hedrick <brooke.t.hedrick@gmail.com> * Update bitnami/moodle/4.2/debian-11/rootfs/opt/bitnami/scripts/libmoodle.sh Co-authored-by: Michiel <mdhont79@gmail.com> Signed-off-by: Brooke Hedrick <brooke.t.hedrick@gmail.com> * Update libmoodle.sh simplified version Signed-off-by: Brooke Hedrick <brooke.t.hedrick@gmail.com> --------- Signed-off-by: Brooke Hedrick <brooke.t.hedrick@gmail.com> Co-authored-by: Michiel <mdhont79@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Capture the --prefix value from MOODLE_INSTALL_EXTRA_ARGS. Use that value when running sql statements to update the moodle database instead of assuming mdl_.
Benefits
Allows support for --prefix which makes it easier to migrate from an existing moodle install to a container based one.
Possible drawbacks
Applicable issues
Additional information