[bitnami/postegresql-repmgr] Added missing postgresql environment variables

[dcamarenaAZO]

Description of the change

Added missing postgresql environment variables regarding connections to README.md

Benefits

Developers can see them without looking into the code.

Possible drawbacks

None

Applicable issues

• workarround for postgresql-repmgr: POSTGRESQL_EXTRA_FLAGS ignored #52130

Additional information

POSTGRESQL_EXTRA_FLAGS is ignored and it is not possible to pass start parameters to PostgreSQL server.

[Mauraza]

Hi @dcamarenaAZO,

Thanks for the contribution! To add environment variables, you need to add them in all postgresql-env.sh.
Could you update this PR with those changes?

[dcamarenaAZO]

Hi @dcamarenaAZO,

Thanks for the contribution! To add environment variables, you need to add them in all postgresql-env.sh. Could you update this PR with those changes?

Hi @Mauraza,

thank you for your answer. Did you have a look at version 11 postgresql-env.sh?
In version-12, 13, 14, 15 and 16 they are also present.

As I stated in the PR, the variables were just missing in the documentation of bitnami/postegresql-repmgr. They are already in the postgresql-env.sh. Technically everything worked. It was just a lack of documentation.

Thanks for your effort. Let me know if you need anything else.

Another question: I'm now using version 15.4. I just saw that version 16 of bitnami/postgresql-repmgr was released on docker hub. Can you tell me where I can find the release notes, changelog or something to know about changes or compatibility from 15.4 to 16?

Thanks, Cheers, Daniel

[Mauraza]

Hi @dcamarenaAZO,

You are right. The env variables are already included, and the configuration is here:

containers/bitnami/postgresql-repmgr/16/debian-11/rootfs/opt/bitnami/scripts/libpostgresql.sh

Lines 982 to 988 in 6577f4f

	postgresql_configure_connections() {
	[[ -n "$POSTGRESQL_MAX_CONNECTIONS" ]] && postgresql_set_property "max_connections" "$POSTGRESQL_MAX_CONNECTIONS"
	[[ -n "$POSTGRESQL_TCP_KEEPALIVES_IDLE" ]] && postgresql_set_property "tcp_keepalives_idle" "$POSTGRESQL_TCP_KEEPALIVES_IDLE"
	[[ -n "$POSTGRESQL_TCP_KEEPALIVES_INTERVAL" ]] && postgresql_set_property "tcp_keepalives_interval" "$POSTGRESQL_TCP_KEEPALIVES_INTERVAL"
	[[ -n "$POSTGRESQL_TCP_KEEPALIVES_COUNT" ]] && postgresql_set_property "tcp_keepalives_count" "$POSTGRESQL_TCP_KEEPALIVES_COUNT"
	([[ -n "$POSTGRESQL_STATEMENT_TIMEOUT" ]] && postgresql_set_property "statement_timeout" "$POSTGRESQL_STATEMENT_TIMEOUT") || true
	}

Another question: I'm now using version 15.4. I just saw that version 16 of bitnami/postgresql-repmgr was released on docker hub. Can you tell me where I can find the release notes, changelog or something to know about changes or compatibility from 15.4 to 16?

You can check the official documentation https://www.postgresql.org/docs/16/upgrading.html

[github-actions]

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

[dcamarenaAZO]

The pull request is just adding some missing environment variables to the documentation.

[Mauraza]

Hi @dcamarenaAZO,

Thanks for the contribution! LGTM!!