-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/grafana] Ensure bitnami/grafana folder is created with usable permissions #52255
Conversation
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
Un-stale |
Hi @bpfoster, Sorry for my late response. Thanks for your contribution! Maybe we could maintain consistency by using |
Hi @CeliaGMqrz no problem for the delay! If we use the Happy to make that change if you'd prefer it that way, just want to confirm the change to the env variable as well as I'm not familiar with the reasoning for separate naming conventions. |
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
Un-stale |
@CeliaGMqrz sounds good. Variable is now named |
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
Un-stale |
Hi @bpfoster, thanks for your feedback. Sorry for the delay after the vacation. The changes have not been applied correctly. Could you fix the DCO issue? |
This follows the examples of other images. Without this folder being created, mounting user init scripts leads to an error on startup: "mkdir: cannot create directory '/bitnami': Permission denied" fixes bitnami#52238 Signed-off-by: Ben Foster <bpfoster@gmail.com>
…rence it, per PR feedback Signed-off-by: Ben Foster <bpfoster@gmail.com>
71aa49e
to
40d60df
Compare
@CeliaGMqrz my apologies for missing the commit signing. Amended the commit and DCO check is now passing. |
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
Un-stale |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @bpfoster
Sorry to keep you waiting with this PR.
I have consulted with the team and we are going to merge these changes for a temporary workaround. I will create an internal task to review the persistence logic of this container in accordance with grafana configuration to adapt this feature in a cleaner way.
Thanks for your contribution!
Description of the change
Ensures that
/bitnami/grafana
folder is created with usable permissions. I believe this follows the examples of other bitnami images.Without this folder being created, adding user init scripts leads to an error on startup:
mkdir: cannot create directory '/bitnami': Permission denied
Benefits
Necessary folders are created with proper permissions so that the image can run as the non-root user.
Possible drawbacks
None
Applicable issues
Additional information