Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix docker-compose.yml links in README.md #53132

Merged
merged 1 commit into from
Nov 27, 2023
Merged

docs: Fix docker-compose.yml links in README.md #53132

merged 1 commit into from
Nov 27, 2023

Conversation

gerardbosch
Copy link
Contributor

@gerardbosch gerardbosch commented Nov 22, 2023 •
edited
Loading

Some links were pointing to the compose file of wordpress image instead of wordpress-nginx.

@gerardbosch
Fix docker-compose.yml paths in README.md
8562f66 
Some links were pointing to the compose file of `wordpress` image instead of `wordpress-nginx`

Signed-off-by: Gerard Bosch <30733556+gerardbosch@users.noreply.github.com>
@github-actions github-actions bot added the triage Triage is needed label Nov 22, 2023
@gerardbosch
Copy link
Contributor Author

Hi there :)
Correct me if this is wrong, but it looked to me that the links of the compose file were pointing to this image https://github.com/bitnami/containers/tree/main/bitnami/wordpress instead of the nginx version. Cheers!

@github-actions github-actions bot added in-progress and removed triage Triage is needed labels Nov 23, 2023
@bitnami-bot bitnami-bot removed the request for review from carrodher November 23, 2023 12:33
andresbono
andresbono approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@andresbono andresbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution! 😄

@andresbono andresbono added the verify Execute verification workflow for these changes label Nov 27, 2023
@andresbono andresbono merged commit 92692ca into bitnami:main Nov 27, 2023
13 checks passed
christian-scheible pushed a commit to christian-scheible/containers that referenced this pull request Dec 7, 2023
@gerardbosch @christian-scheible
docs: Fix docker-compose.yml links in README.md (bitnami#53132)
2a280dc 
Fix docker-compose.yml paths in README.md

Some links were pointing to the compose file of `wordpress` image instead of `wordpress-nginx`

Signed-off-by: Gerard Bosch <30733556+gerardbosch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresbono andresbono andresbono approved these changes

Assignees

@andresbono andresbono

Labels
solved verify Execute verification workflow for these changes wordpress-nginx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gerardbosch @andresbono @carrodher