-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(keycloak): expose default ports #53963
Conversation
We are going to review this logic internally and we will notify you in this PR when there is any news. |
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
@mdhont any update? |
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary. |
@mdhont any update? |
Sorry for the delay in getting back to you, it seems we lost track of this ticket. We are going to update our systems to include this change from now on. |
@maxime1907, could you rebase the commit, after that we can land it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
Signed-off-by: maxime1907 <19607336+maxime1907@users.noreply.github.com>
f5ea261
to
2fdc0a7
Compare
done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
Description of the change
Expose default keycloak ports 8080 and 8443
Taken from here:
Benefits
Use this image as a service in gitlab CI
Docker best practices
Possible drawbacks
NONE
Applicable issues
NONE
Additional information
NONE