Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(keycloak): expose default ports #53963

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

maxime1907
Copy link
Contributor

@maxime1907 maxime1907 commented Dec 19, 2023

Description of the change

Expose default keycloak ports 8080 and 8443
Taken from here:

Benefits

Use this image as a service in gitlab CI
Docker best practices

Possible drawbacks

NONE

Applicable issues

NONE

Additional information

NONE

@github-actions github-actions bot added keycloak triage Triage is needed labels Dec 19, 2023
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Dec 20, 2023
@github-actions github-actions bot removed the triage Triage is needed label Dec 20, 2023
@github-actions github-actions bot removed the request for review from javsalgar December 20, 2023 19:23
@github-actions github-actions bot requested a review from mdhont December 20, 2023 19:23
@mdhont
Copy link
Contributor

mdhont commented Dec 27, 2023

We are going to review this logic internally and we will notify you in this PR when there is any news.
Thank you very much for the contribution!

Copy link

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Jan 12, 2024
@maxime1907
Copy link
Contributor Author

@mdhont any update?

@github-actions github-actions bot removed the stale 15 days without activity label Jan 13, 2024
Copy link

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Jan 29, 2024
Copy link

github-actions bot commented Feb 4, 2024

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.

@github-actions github-actions bot added the solved label Feb 4, 2024
@bitnami-bot bitnami-bot added stale 15 days without activity and removed stale 15 days without activity labels Feb 4, 2024
@bitnami-bot bitnami-bot closed this Feb 4, 2024
@maxime1907
Copy link
Contributor Author

@mdhont any update?

@javsalgar javsalgar reopened this Feb 7, 2024
@github-actions github-actions bot added triage Triage is needed and removed in-progress solved labels Feb 7, 2024
@jotamartos
Copy link
Contributor

Sorry for the delay in getting back to you, it seems we lost track of this ticket. We are going to update our systems to include this change from now on.

@github-actions github-actions bot removed the stale 15 days without activity label Feb 8, 2024
@mdhont
Copy link
Contributor

mdhont commented Feb 8, 2024

@maxime1907, could you rebase the commit, after that we can land it

@mdhont mdhont assigned mdhont and unassigned jotamartos Feb 8, 2024
@mdhont mdhont requested review from mdhont and removed request for jotamartos February 8, 2024 10:29
mdhont
mdhont previously approved these changes Feb 8, 2024
Copy link
Contributor

@mdhont mdhont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Signed-off-by: maxime1907 <19607336+maxime1907@users.noreply.github.com>
@maxime1907
Copy link
Contributor Author

@maxime1907, could you rebase the commit, after that we can land it

done!

Copy link
Contributor

@mdhont mdhont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@mdhont mdhont merged commit 094e906 into bitnami:main Feb 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keycloak solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants