Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitami/schema-registry] Integrated Schema Registry documentation with instructions for SSL setup #54308

Merged
merged 11 commits into from
Jan 24, 2024

Conversation

ETisREAL
Copy link
Contributor

@ETisREAL ETisREAL commented Dec 29, 2023

After receiving insights on how to properly setup the Schema Registry container with an SSL listener, I updated the README docs to include a Security section that goes over how to set up an SSL listener.
I also provided a working example of a docker-compose.yaml file I use for local development

Of course, feel free to make any adjustments if it doesn't sound clear or something is incorrect.

Thank you.

fixes: #53688

…h instructions for SSL setup

Signed-off-by: ETisREAL <etpelosato2010@hotmail.it>
ETisREAL added 3 commits December 29, 2023 20:37
Signed-off-by: ETisREAL <etpelosato2010@hotmail.it>
Signed-off-by: ETisREAL <etpelosato2010@hotmail.it>
Signed-off-by: ETisREAL <etpelosato2010@hotmail.it>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Jan 1, 2024
@github-actions github-actions bot removed the triage Triage is needed label Jan 1, 2024
@github-actions github-actions bot removed the request for review from javsalgar January 1, 2024 19:18
@github-actions github-actions bot requested a review from fevisera January 1, 2024 19:18
Copy link

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Jan 17, 2024
@fevisera
Copy link
Contributor

Hi @ETisREAL,

Thank you for creating this pull request and sorry for the delay.

Please consider the suggestions I added in the comments.

ETisREAL and others added 3 commits January 19, 2024 18:09
Co-authored-by: Felipe V.C. Serafim <43246350+fevisera@users.noreply.github.com>
Signed-off-by: Ettore Pelosato <113307574+ETisREAL@users.noreply.github.com>
Co-authored-by: Felipe V.C. Serafim <43246350+fevisera@users.noreply.github.com>
Signed-off-by: Ettore Pelosato <113307574+ETisREAL@users.noreply.github.com>
Co-authored-by: Felipe V.C. Serafim <43246350+fevisera@users.noreply.github.com>
Signed-off-by: Ettore Pelosato <113307574+ETisREAL@users.noreply.github.com>
@ETisREAL
Copy link
Contributor Author

Hello @fevisera

no worries at all! I'm sure you guys are overburdened already. Just happy I can help :)

Signed-off-by: Ettore Pelosato <113307574+ETisREAL@users.noreply.github.com>
@github-actions github-actions bot removed the stale 15 days without activity label Jan 20, 2024
Signed-off-by: Ettore Pelosato <113307574+ETisREAL@users.noreply.github.com>
Signed-off-by: Ettore Pelosato <113307574+ETisREAL@users.noreply.github.com>
Copy link
Contributor

@fevisera fevisera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fevisera fevisera merged commit 85ae26f into bitnami:main Jan 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
schema-registry solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/schema-registry] can't setup in SSL
4 participants