-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitami/schema-registry] Integrated Schema Registry documentation with instructions for SSL setup #54308
Conversation
…h instructions for SSL setup Signed-off-by: ETisREAL <etpelosato2010@hotmail.it>
Signed-off-by: ETisREAL <etpelosato2010@hotmail.it>
Signed-off-by: ETisREAL <etpelosato2010@hotmail.it>
Signed-off-by: ETisREAL <etpelosato2010@hotmail.it>
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
Hi @ETisREAL, Thank you for creating this pull request and sorry for the delay. Please consider the suggestions I added in the comments. |
Co-authored-by: Felipe V.C. Serafim <43246350+fevisera@users.noreply.github.com> Signed-off-by: Ettore Pelosato <113307574+ETisREAL@users.noreply.github.com>
Co-authored-by: Felipe V.C. Serafim <43246350+fevisera@users.noreply.github.com> Signed-off-by: Ettore Pelosato <113307574+ETisREAL@users.noreply.github.com>
Co-authored-by: Felipe V.C. Serafim <43246350+fevisera@users.noreply.github.com> Signed-off-by: Ettore Pelosato <113307574+ETisREAL@users.noreply.github.com>
Hello @fevisera no worries at all! I'm sure you guys are overburdened already. Just happy I can help :) |
Signed-off-by: Ettore Pelosato <113307574+ETisREAL@users.noreply.github.com>
Signed-off-by: Ettore Pelosato <113307574+ETisREAL@users.noreply.github.com>
Signed-off-by: Ettore Pelosato <113307574+ETisREAL@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
After receiving insights on how to properly setup the Schema Registry container with an SSL listener, I updated the README docs to include a
Security
section that goes over how to set up an SSL listener.I also provided a working example of a docker-compose.yaml file I use for local development
Of course, feel free to make any adjustments if it doesn't sound clear or something is incorrect.
Thank you.
fixes: #53688