Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/postgresql] Created seperate config directory to allow for readonlyrootfilesystem #54532

Closed
wants to merge 3 commits into from

Conversation

JKrehling
Copy link

Description of the change

Moves the config files into the conf directory on startup to allow for readOnlyRootFilesystem

Benefits

Conf directory can be mounted separately without rewriting all the other bootstrap scripts

Possible drawbacks

Anyone mounting files directly into the conf directory would have them overwritten, they would have to mount them into temp-conf.

Applicable issues

Additional information

docker build -t postgresql:rootest .

docker run -it --read-only --tmpfs=/tmp --tmpfs=/opt/bitnami/postgresql/conf --tmpfs=/opt/bitnami/postgresql/tmp -e ALLOW_EMPTY_PASSWORD=yes postgresql:rootest

@github-actions github-actions bot added postgresql triage Triage is needed labels Jan 9, 2024
@JKrehling JKrehling changed the title Created seperate config directory to allow for readonlyrootfilesystem [bitnami/postgresql] Created seperate config directory to allow for readonlyrootfilesystem Jan 9, 2024
@javsalgar javsalgar added the verify Execute verification workflow for these changes label Jan 10, 2024
@javsalgar
Copy link
Contributor

Hi!

Thank you so much for the PR! Could you fix the DCO issue?

@JKrehling JKrehling force-pushed the postgresql-read-only branch 2 times, most recently from af3df04 to aac32fd Compare January 10, 2024 15:48
…eadonlyrootfilesystem

Signed-off-by: Jon Krehling <jkpublicweb@gmail.com>
@JKrehling
Copy link
Author

Hi!

Thank you so much for the PR! Could you fix the DCO issue?

Should be good now. Thanks!

… of overwriting all

Signed-off-by: Jon Krehling <jkpublicweb@gmail.com>
@JKrehling
Copy link
Author

I did change the cp flag to use -u which should only update the files in the working conf directory if people are mounting things in there as well. So it should just add the files if conf is empty.

@github-actions github-actions bot removed the triage Triage is needed label Jan 11, 2024
@github-actions github-actions bot removed the request for review from javsalgar January 11, 2024 08:34
@JKrehling JKrehling marked this pull request as ready for review January 17, 2024 18:16
Signed-off-by: Carlos Rodríguez Hernández <carlosrh@vmware.com>
Copy link

github-actions bot commented Feb 8, 2024

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Feb 8, 2024
@CeliaGMqrz CeliaGMqrz removed the stale 15 days without activity label Feb 8, 2024
@JKrehling
Copy link
Author

@CeliaGMqrz
Hi Celia,
Was there something more needed from my end here for this review.

Thanks!

@CeliaGMqrz
Copy link
Contributor

Hi @JKrehling,

Thanks for your contribution. Our team is currently evaluating the best approach to address this issue. We appreciate your patience and support as we work towards a resolution.

Copy link

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Feb 24, 2024
@CeliaGMqrz
Copy link
Contributor

Hi @JKrehling

Thanks for your efforts in addressing this issue. Sorry for not notifying you sooner.

As I mentioned, our team was already working on implementing this feature to ensure consistency with other assets. This feature is now available in the latest version, so we will be closing the PR.

If you encounter any problems or difficulties, please feel free to open an issue. We appreciate your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
postgresql solved stale 15 days without activity verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/postgresql] Supporting read only filesystems
4 participants