-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/postgresql] Created seperate config directory to allow for readonlyrootfilesystem #54532
Conversation
Hi! Thank you so much for the PR! Could you fix the DCO issue? |
af3df04
to
aac32fd
Compare
…eadonlyrootfilesystem Signed-off-by: Jon Krehling <jkpublicweb@gmail.com>
aac32fd
to
89c3acd
Compare
Should be good now. Thanks! |
… of overwriting all Signed-off-by: Jon Krehling <jkpublicweb@gmail.com>
I did change the cp flag to use -u which should only update the files in the working conf directory if people are mounting things in there as well. So it should just add the files if conf is empty. |
Signed-off-by: Carlos Rodríguez Hernández <carlosrh@vmware.com>
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
@CeliaGMqrz Thanks! |
Hi @JKrehling, Thanks for your contribution. Our team is currently evaluating the best approach to address this issue. We appreciate your patience and support as we work towards a resolution. |
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
Hi @JKrehling Thanks for your efforts in addressing this issue. Sorry for not notifying you sooner. As I mentioned, our team was already working on implementing this feature to ensure consistency with other assets. This feature is now available in the latest version, so we will be closing the PR. If you encounter any problems or difficulties, please feel free to open an issue. We appreciate your feedback. |
Description of the change
Moves the config files into the conf directory on startup to allow for readOnlyRootFilesystem
Benefits
Conf directory can be mounted separately without rewriting all the other bootstrap scripts
Possible drawbacks
Anyone mounting files directly into the conf directory would have them overwritten, they would have to mount them into temp-conf.
Applicable issues
Additional information
docker build -t postgresql:rootest .
docker run -it --read-only --tmpfs=/tmp --tmpfs=/opt/bitnami/postgresql/conf --tmpfs=/opt/bitnami/postgresql/tmp -e ALLOW_EMPTY_PASSWORD=yes postgresql:rootest