[bitnami/opencart] Fix opencart admin urls on OPENCART_ENABLE_HTTPS=true #64995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kirilov <kirilov@clolytic.bg>
carrodher
added
verify
rafariossaa
reviewed
Apr 10, 2024
Comment on lines
+339
to
+340
| opencart_conf_set HTTPS_SERVER "${http_url}/administration/" "$OPENCART_ADMIN_CONF_FILE" | ||
| opencart_conf_set HTTPS_CATALOG "${http_url}/" "$OPENCART_ADMIN_CONF_FILE" |
There was a problem hiding this comment.
Is setting the HTTPS_xxx environment variables needed for the case of HTTP ?
There was a problem hiding this comment.
I believe similar issue could happen if those are not set properly when OPENCART_ENABLE_HTTPS is false.
Also in this way it will be consistent with the configuration for the client area:
opencart_conf_set HTTP_SERVER "${http_url}/"
opencart_conf_set HTTPS_SERVER "${http_url}/"
There was a problem hiding this comment.
@rafariossaa were you able to check this?
There was a problem hiding this comment.
Sorry for the delay. I am checking this.
rafariossaa
approved these changes
Apr 24, 2024
|
The release the includes this fix is: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for bitnami/charts#25038