[bitnami/mediawiki] Add env var to control skipping config validation during startup #65729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Iain MacDonald <IJMacD@gmail.com>
IJMacD
force-pushed
the
skip-update-validation
branch
from
cab315e
to
92bc041
Compare
iain-ilearner
changed the title
carrodher
added
verify
dgomezleon
reviewed
Apr 29, 2024
|
Thank you for taking time to look at this PR, but I'm unable to see any of the minor changes you referred to. Are they in this PR on Github? |
dgomezleon
reviewed
May 6, 2024
There was a problem hiding this comment.
Sorry @iain-ilearner .
It seems the suggestions were not submitted.
dgomezleon
reviewed
May 6, 2024
bitnami/mediawiki/1/debian-12/rootfs/opt/bitnami/scripts/libmediawiki.sh
Outdated
Show resolved
Hide resolved
…diawiki.sh Thanks for the suggestions Co-authored-by: David Gomez <davidbhlm@gmail.com> Signed-off-by: Iain MacDonald <151295347+iain-ilearner@users.noreply.github.com>
dgomezleon
reviewed
May 6, 2024
|
The reason I didn't add it on line 127 initially was because line 95 checks if we're in an empty dir before doing the install/upgrade. I'm not sure how you could get a |
Signed-off-by: Iain MacDonald <IJMacD@gmail.com>
IJMacD
force-pushed
the
skip-update-validation
branch
from
5031f36
to
cca5ace
Compare
dgomezleon
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested/requested in #65721 (comment) here's a PR introducing a new environment variable that controls whether or not validation is performed of configuration file during database upgrade at container start-up.
This allows the use deprecated values (such as
$wgAllowImageTag) in LocalSettings.phpThis PR also adds a log message after connecting to the database to better indicate which part of the start-up process is running.