Fix issue with SONARQUBE_EXTRA_PROPERTIES containing equals

[akhamar]

Description of the change

Fix an issue with sonarqube script that do not extract extra env var (SONARQUBE_EXTRA_PROPERTIES)

Benefits

Fix an issue

Possible drawbacks

None ?

Applicable issues

N/A

Additional information

Invalid replacement of extra vars (SONARQUBE_EXTRA_PROPERTIES)

Script

#!/bin/bash

SONARQUBE_EXTRA_PROPERTIES=sonar.core.serverBaseURL=https://example.com,sonar.auth.saml.enabled=true,sonar.auth.saml.applicationId=Example,sonar.auth.saml.providerName=SAML,sonar.auth.saml.providerId=https://example.com/saml2?idpid=IDEXAMPLE,sonar.auth.saml.loginUrl=https://example.com/saml2/idp?idpid=IDEXAMPLE,sonar.auth.saml.user.login=login,sonar.auth.saml.user.name=username,sonar.auth.saml.user.email=email
echo "SONARQUBE_EXTRA_PROPERTIES: $SONARQUBE_EXTRA_PROPERTIES"

IFS=',' read -r -a additional_properties <<< "$SONARQUBE_EXTRA_PROPERTIES"
if [[ "${#additional_properties[@]}" -gt 0 ]]; then
    info "Adding properties provided via SONARQUBE_EXTRA_PROPERTIES to sonar.properties"
    for property in "${additional_properties[@]}"; do
        echo "${property%=*}=${property#*=}"
    done
fi

Invalid result

SONARQUBE_EXTRA_PROPERTIES: sonar.core.serverBaseURL=https://example.com,sonar.auth.saml.enabled=true,sonar.auth.saml.applicationId=Example,sonar.auth.saml.providerName=SAML,sonar.auth.saml.providerId=https://example.com/saml2?idpid=IDEXAMPLE,sonar.auth.saml.loginUrl=https://example.com/saml2/idp?idpid=IDEXAMPLE,sonar.auth.saml.user.login=login,sonar.auth.saml.user.name=username,sonar.auth.saml.user.email=email
info: No menu item 'Adding properties provided via SONARQUBE_EXTRA_PROPERTIES to sonar.properties' in node '(dir)Top'
sonar.core.serverBaseURL=https://example.com
sonar.auth.saml.enabled=true
sonar.auth.saml.applicationId=Example
sonar.auth.saml.providerName=SAML
sonar.auth.saml.providerId=https://example.com/saml2?idpid=https://example.com/saml2?idpid=IDEXAMPLE
sonar.auth.saml.loginUrl=https://example.com/saml2/idp?idpid=https://example.com/saml2/idp?idpid=IDEXAMPLE
sonar.auth.saml.user.login=login
sonar.auth.saml.user.name=username
sonar.auth.saml.user.email=email

sonar.auth.saml.providerId=https://example.com/saml2?idpid=https://example.com/saml2?idpid=IDEXAMPLE

Invalid double replacement

Correct replacement of extra vars (SONARQUBE_EXTRA_PROPERTIES)

Script

#!/bin/bash

SONARQUBE_EXTRA_PROPERTIES=sonar.core.serverBaseURL=https://example.com,sonar.auth.saml.enabled=true,sonar.auth.saml.applicationId=Example,sonar.auth.saml.providerName=SAML,sonar.auth.saml.providerId=https://example.com/saml2?idpid=IDEXAMPLE,sonar.auth.saml.loginUrl=https://example.com/saml2/idp?idpid=IDEXAMPLE,sonar.auth.saml.user.login=login,sonar.auth.saml.user.name=username,sonar.auth.saml.user.email=email
echo "SONARQUBE_EXTRA_PROPERTIES: $SONARQUBE_EXTRA_PROPERTIES"

IFS=',' read -r -a additional_properties <<< "$SONARQUBE_EXTRA_PROPERTIES"
if [[ "${#additional_properties[@]}" -gt 0 ]]; then
    info "Adding properties provided via SONARQUBE_EXTRA_PROPERTIES to sonar.properties"
    for property in "${additional_properties[@]}"; do
        echo "${property%%=*}=${property#*=}"
    done
fi

Correct result

SONARQUBE_EXTRA_PROPERTIES: sonar.core.serverBaseURL=https://example.com,sonar.auth.saml.enabled=true,sonar.auth.saml.applicationId=Example,sonar.auth.saml.providerName=SAML,sonar.auth.saml.providerId=https://example.com/saml2?idpid=IDEXAMPLE,sonar.auth.saml.loginUrl=https://example.com/saml2/idp?idpid=IDEXAMPLE,sonar.auth.saml.user.login=login,sonar.auth.saml.user.name=username,sonar.auth.saml.user.email=email
info: No menu item 'Adding properties provided via SONARQUBE_EXTRA_PROPERTIES to sonar.properties' in node '(dir)Top'
sonar.core.serverBaseURL=https://example.com
sonar.auth.saml.enabled=true
sonar.auth.saml.applicationId=Example
sonar.auth.saml.providerName=SAML
sonar.auth.saml.providerId=https://example.com/saml2?idpid=IDEXAMPLE
sonar.auth.saml.loginUrl=https://example.com/saml2/idp?idpid=IDEXAMPLE
sonar.auth.saml.user.login=login
sonar.auth.saml.user.name=username
sonar.auth.saml.user.email=email

sonar.auth.saml.providerId=https://example.com/saml2?idpid=IDEXAMPLE

Correct replacement

[github-actions]

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

[andresbono]

Thank you for your contribution!

[andresbono]

The next release of the container images will include your fix. Thanks again!