-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/kong]: fix libkong.sh kong_stop function #69389
[bitnami/kong]: fix libkong.sh kong_stop function #69389
Conversation
63d49ea
to
7a38f26
Compare
Signed-off-by: xavbourdeau <xavier.bourdeau@qima.com>
7a38f26
to
d997c72
Compare
Keep prefix parameter Signed-off-by: Gonzalo Gómez Gracia <gongomgra@users.noreply.github.com>
Hi @xavbourdeau, Thanks for your contribution. I have updated the code to keep using the
I will share your contribution with the rest of the team and merge it when they have finished checking it. I will keep you posted. |
Hi @gongomgra, thanks you for the fix. Do you know when a new image tag will be created on docker hub repo ? |
Hi @xavbourdeau we are having issues testing the new solution on our side and we are working on a fix. It should be released once solved. I will keep you posted. |
@xavbourdeau we have just released a new revision of the kong image including your changes.
|
Description of the change
kong_stop function while testing additional script use
kong stop -c ...
and there is not-c
argumentn or-p
arguments.If you set
metrics: true
at bitnami/kong helm chart, pods will fail with following errorBenefits
kong will not fail while loading user's custom files (like the one used for the metrics)
Possible drawbacks
N/A
Applicable issues
#69390
Additional information
N/A