Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/kong]: fix libkong.sh kong_stop function #69389

Conversation

xavbourdeau
Copy link
Contributor

@xavbourdeau xavbourdeau commented Jul 19, 2024

Description of the change

kong_stop function while testing additional script use kong stop -c ... and there is not -c argumentn or -p arguments.
If you set metrics: true at bitnami/kong helm chart, pods will fail with following error

kong: unrecognized parameter: c

Benefits

kong will not fail while loading user's custom files (like the one used for the metrics)

Possible drawbacks

N/A

Applicable issues

#69390

Additional information

N/A

@github-actions github-actions bot added kong triage Triage is needed labels Jul 19, 2024
@github-actions github-actions bot requested a review from javsalgar July 19, 2024 10:21
@xavbourdeau xavbourdeau force-pushed the fix/kong/libkong.sh/wrong-kong-stop-parameters branch 2 times, most recently from 63d49ea to 7a38f26 Compare July 19, 2024 12:49
Signed-off-by: xavbourdeau <xavier.bourdeau@qima.com>
@xavbourdeau xavbourdeau force-pushed the fix/kong/libkong.sh/wrong-kong-stop-parameters branch from 7a38f26 to d997c72 Compare July 19, 2024 15:40
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Jul 19, 2024
@github-actions github-actions bot removed the triage Triage is needed label Jul 19, 2024
@github-actions github-actions bot removed the request for review from javsalgar July 19, 2024 16:46
@github-actions github-actions bot requested a review from gongomgra July 19, 2024 16:46
Keep prefix parameter

Signed-off-by: Gonzalo Gómez Gracia <gongomgra@users.noreply.github.com>
@gongomgra
Copy link
Contributor

Hi @xavbourdeau,

Thanks for your contribution. I have updated the code to keep using the -p, --prefix parameter as it is supported by the kong stop command.

root@8373ff1d0cac:/# kong stop --help
Usage: kong stop [OPTIONS]

Stop a running Kong node (Nginx and other configured services) in given
prefix directory.

This command sends a SIGTERM signal to Nginx.

Options:
 -p,--prefix      (optional string) prefix Kong is running at
 --v              verbose
 --vv             debug

I will share your contribution with the rest of the team and merge it when they have finished checking it. I will keep you posted.

@gongomgra gongomgra merged commit 2c338a6 into bitnami:main Jul 22, 2024
9 checks passed
@xavbourdeau xavbourdeau deleted the fix/kong/libkong.sh/wrong-kong-stop-parameters branch July 22, 2024 16:21
@xavbourdeau
Copy link
Contributor Author

Hi @gongomgra, thanks you for the fix. Do you know when a new image tag will be created on docker hub repo ?

@gongomgra
Copy link
Contributor

Hi @xavbourdeau we are having issues testing the new solution on our side and we are working on a fix. It should be released once solved. I will keep you posted.

@gongomgra
Copy link
Contributor

@xavbourdeau we have just released a new revision of the kong image including your changes.

bitnami/kong:3.7.1-debian-12-r4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kong solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants