Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[.vib] Add chainloop containers VIB files #70431

Merged
merged 1 commit into from
Aug 1, 2024
Merged

[.vib] Add chainloop containers VIB files #70431

merged 1 commit into from
Aug 1, 2024

Conversation

migruiz4
Copy link
Member

Description of the change

Add basic vib-verify pipelines for scratch containers.

@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label Jul 30, 2024
@migruiz4
[.vib] Add chainloop containers VIB files
979a083 
Signed-off-by: Miguel Ruiz <miruiz@vmware.com>
@carrodher carrodher requested review from fmulero and removed request for rafariossaa July 31, 2024 16:26
@carrodher carrodher assigned fmulero and unassigned rafariossaa Jul 31, 2024
fmulero
fmulero approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@fmulero fmulero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just to double check. Can these containers start and keep running without any configuration or dependency? If not, please add the runtime_parameters field.

@migruiz4
Copy link
Member Author

migruiz4 commented Aug 1, 2024

@fmulero They can't, but they are scratch containers so adding runtime_parameters is pointless. We add basic tests as we do in other scratch containers such as charts-syncer, oras, etc.

@migruiz4 migruiz4 merged commit a6a7cd5 into main Aug 1, 2024
10 checks passed
@migruiz4 migruiz4 deleted the add-vib-chainloop branch August 1, 2024 11:40
@github-actions github-actions bot added the solved label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmulero fmulero fmulero approved these changes

Assignees

@fmulero fmulero

Labels
bitnami solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@migruiz4 @fmulero @rafariossaa @bitnami-bot