Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/postgresql-repmgr] Support running scripts on primary node when container starts #70737

Conversation

ThomasRasmussen
Copy link

Description of the change

This PR will add support for putting scripts in /docker-entrypoint-startdb.d/ and have these executed every time the container starts (limited to the PRIMARY node). Works the same way that /docker-entrypoint-initdb.d however this is limited to only running when database is initialized.

Benefits

Run validationscripts or other generic scripts every time the database container starts

Possible drawbacks

If scripts are not idempotent then this may impact the database.

Applicable issues

Additional information

Change sql-mysql.sh script to use default moodle environment variables
to connect to database bitnami#68054

Signed-off-by: Thomas Lønskov Luther <rasmussen.thomas@gmail.com>
Signed-off-by: Thomas Lønskov Luther <rasmussen.thomas@gmail.com>
…is started (bitnami#70606)

Signed-off-by: Thomas Lønskov Luther <rasmussen.thomas@gmail.com>
@github-actions github-actions bot added the triage Triage is needed label Aug 7, 2024
@github-actions github-actions bot requested a review from carrodher August 7, 2024 11:08
@carrodher
Copy link
Member

Thank you for initiating this pull request. We appreciate your effort. Just a friendly reminder that it's important to sign your commits. Adding your signature certifies that you either authored the patch or have the necessary rights to contribute the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines.

Feel free to reach out if you have any questions or need assistance with the signing process.

@ThomasRasmussen
Copy link
Author

@carrodher hmm... don't know why the other commits got to be a part of this PR :-( Apparently I mistankenly merged in another branch into this one... is it possible for me to remove these commits?

@javsalgar
Copy link
Contributor

Hi,

It seems the PR is including changes for Moodle, which I believe they are not expected. Could you check it?

@javsalgar javsalgar changed the title Support running scripts on primary node when container starts [bitnami/postgresql-repmgr] Support running scripts on primary node when container starts Aug 12, 2024
…is started (bitnami#70606)

Signed-off-by: Thomas Lønskov Luther <rasmussen.thomas@gmail.com>
…is started (bitnami#70606)

Signed-off-by: Thomas Lønskov Luther <rasmussen.thomas@gmail.com>
…smussen/bitnami-containers into feature/postgres-repmgr_scripts
…smussen/bitnami-containers into feature/postgres-repmgr_scripts
Copy link

github-actions bot commented Sep 1, 2024

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Sep 1, 2024
Copy link

github-actions bot commented Sep 7, 2024

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.

@github-actions github-actions bot added the solved label Sep 7, 2024
@bitnami-bot bitnami-bot added stale 15 days without activity and removed stale 15 days without activity labels Sep 7, 2024
@bitnami-bot bitnami-bot closed this Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved stale 15 days without activity triage Triage is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/postgresql-repmgr] Running custom script on primary database when container starting
4 participants