Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read config file from absolute and relative references #111

Merged
merged 4 commits into from
Sep 6, 2024

Conversation

wcmjunior
Copy link
Contributor

Read configuration file from absolute and relative references.

Description of the change

Remove duplication in config file handling and allow for relative references as the previous implementation would only support absolute file references.

Benefits

Better support for cicd pipelines.

Possible drawbacks

None that I know of.

Applicable issues

Additional information

Checklist

  • Version bumped in package.json and package-lock.json according to semver.
  • New features are documented in the README.md
  • New features contain a new test at the tests folder
  • All tests pass running npm test

Signed-off-by: Wilson de Carvalho <796900+wcmjunior@users.noreply.github.com>
Signed-off-by: Wilson de Carvalho <796900+wcmjunior@users.noreply.github.com>
Signed-off-by: Wilson de Carvalho <796900+wcmjunior@users.noreply.github.com>
Signed-off-by: Wilson de Carvalho <796900+wcmjunior@users.noreply.github.com>
Copy link
Contributor

@fmulero fmulero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @wcmjunior LGTM

@fmulero fmulero merged commit 721a46e into bitnami:main Sep 6, 2024
4 checks passed
@github-actions github-actions bot added the solved label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants