Allow descriptions in skipped lines #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jota Martos <jotamartos@vmware.com>
Signed-off-by: Jota Martos <jotamartos@vmware.com>
fmulero
reviewed
Oct 11, 2023
There was a problem hiding this comment.
Thanks a lot @jotamartos I left a little comment. Please take it a look.
Signed-off-by: Jota Martos <jotamartos@vmware.com>
pearsonradu
pushed a commit
to pearsonradu/readme-generator-for-helm
that referenced
this pull request
Oct 17, 2023
…skip-lines Allow descriptions in skipped lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This change allows including descriptions in the lines that we do not want to include in the readme (@Skip)
Benefits
Allows not including a parameter in the README but including the description in the values.yaml file
Possible drawbacks
None
Applicable issues
Related to this other PR
bitnami/charts#19841
Additional information
Checklist
package.jsonandpackage-lock.jsonaccording to semver.testsfoldernpm test