Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to section loss when parameters section is empty #80

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Fix to section loss when parameters section is empty #80

merged 3 commits into from
Oct 24, 2023

Conversation

fmulero
Copy link
Contributor

@fmulero fmulero commented Oct 20, 2023

Description of the change

Revisit how we are finding the Parameters section and the tables with the parameters.

Benefits

Fix an error detected with the indexes which was causing #72

Possible drawbacks

None identified

Applicable issues

Checklist

  • Version bumped in package.json and package-lock.json according to semver.
  • New features are documented in the README.md
  • New features contain a new test at the tests folder
  • All tests pass running npm test

@fmulero
Fix issue when parmeters section is empty
245ac9a 
Signed-off-by: Fran Mulero <fmulero@vmware.com>
@fmulero
Merge remote-tracking branch 'origin/main' into bugfix/empty-parameters
584d567
@fmulero
Fix linter
02bdb0c 
Signed-off-by: Fran Mulero <fmulero@vmware.com>
@fmulero fmulero merged commit 24c5ba9 into main Oct 24, 2023
1 check passed
@fmulero fmulero deleted the bugfix/empty-parameters branch October 24, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jotamartos jotamartos jotamartos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

An empty ## Parameters section in README leads to loss of following section header
2 participants
@fmulero @jotamartos