Fix missing hash verification - #49
Draft
ofalvai wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Android and iOS skipped hash verification entirely for a full (non-diff), unsigned update — the most common deployment setup — so a corrupted or tampered download could install with no integrity check. Diff updates were still verified in the same unsigned config, so the gap was specific to full updates.
The e2e suite never caught this because the mock update server sent a random
package_hashdisconnected from the actual bundle it served.What
CodePushUpdateManager.java) and iOS (CodePushPackage.m): hash verification now always runs, regardless of diff/full or signing status. Signature verification still only runs when a public key is configured.Decisions
localPackage.install.revert.dorevertto match actual native rollback behavior (rejected on the first revert, not the second) — it only passed before because the mock's random hash bug made a re-served identical package look like a different one on retry.