Fix CPU dequantize_4bit output shape for 1-D inputs - #2048
Open
2sumtech wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2047
The native CPU
dequantize_4bitmutated a 1-Dshapeto(1, n)before allocating the output, so even-length 1-D inputs dequantized to 2-D. The(1, n)view is only needed for the C++ kernel's 2-D indexing, andm = prod(shape[:-1])is already 1 for 1-D inputs — this PR drops the mutation so the output keeps the caller-provided shape, matching the CUDA backend, the default/MPS backends, the registered fake kernel, and the CPU backend's own odd-length fallback path.(1, n) -> (n,).test_dequantize_4bit_1d_shape(24 params): fails 12/12 on CPU without the fix, passes 24/24 (cpu+mps) with it.Test4bitBlockwiseQuantOps: 536 passed, 24 skipped, 60 xfailed.test_functional.py -k 4bit: 1958 passed. Full pre-commit suite passes on touched files.Disclosure: prepared with AI assistance (Claude Code); I reviewed the change and take responsibility for it.