Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Resolves issues with return types on most GET / PUT / PATCH / POST requests.
Most of the endpoints look like this;
This indicates that you can access your list of tickets by calling
Problem is that the data actually returned from the
this.get()
call is returned as;This should ensure that folks can more reliably use this client with Typescript.
This also fixes a typo in the
macros.js
file;this.gettAll(
->this.getAll(
Related Issue(s)
Additional Information
(This will fix/break(?) types returned. I would expect TS folks are using something like
const ticketsRes = await showMany() as {response: object, result: Ticket[]}
given that trying to access tickets as it was previously typed would fail)Test Cases
Include any test cases or steps you took to test your changes. If you have added new functionality, please include relevant unit tests.
Documentation
Checklist