fix: allow sms mfa to be toggled on and off (#3636)

bloom-housing · Sep 5, 2023 · 92add25 · 92add25
1 parent 01d06ae
commit 92add25
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 12 deletions.
diff --git a/sites/partners/.env.template b/sites/partners/.env.template
@@ -10,3 +10,4 @@ CLOUDINARY_KEY='abcxyz'
 CLOUDINARY_SIGNED_PRESET='test123'
 MAPBOX_TOKEN=
 FEATURE_LISTINGS_APPROVAL=FALSE
+SHOW_SMS_MFA=TRUE
diff --git a/sites/partners/next.config.js b/sites/partners/next.config.js
@@ -43,6 +43,7 @@ module.exports = withBundleAnalyzer(
       listingServiceUrl: BACKEND_API_BASE + LISTINGS_QUERY,
       idleTimeout: process.env.IDLE_TIMEOUT,
       showDuplicates: process.env.SHOW_DUPLICATES === "TRUE",
+      showSmsMfa: (process.env.SHOW_SMS_MFA || "TRUE") === "TRUE", // SMS on by default
       cloudinaryCloudName: process.env.CLOUDINARY_CLOUD_NAME,
       cloudinaryKey: process.env.CLOUDINARY_KEY,
       cloudinarySignedPreset: process.env.CLOUDINARY_SIGNED_PRESET,

diff --git a/sites/partners/src/components/users/FormSignInMFAType.tsx b/sites/partners/src/components/users/FormSignInMFAType.tsx
@@ -46,9 +46,11 @@ const FormSignInMFAType = ({
         <h2 className="form-card__title is-borderless">
           {t("nav.signInMFA.verificationChoiceMainTitle")}
         </h2>
-        <p className="form-card__sub-title">
-          {t("nav.signInMFA.verificationChoiceSecondaryTitle")}
-        </p>
+        {process.env.showSmsMfa && (
+          <p className="form-card__sub-title">
+            {t("nav.signInMFA.verificationChoiceSecondaryTitle")}
+          </p>
+        )}
       </div>
       <FormSignInErrorBox
         errors={errors}
@@ -80,15 +82,17 @@ const FormSignInMFAType = ({
               {t("nav.signInMFA.verifyByEmail")}
             </Button>
           </div>
-          <div className="text-center mt-6">
-            <Button
-              styleType={AppearanceStyleType.accentCool}
-              data-testid="verify-by-phone"
-              onClick={smsOnClick}
-            >
-              {t("nav.signInMFA.verifyByPhone")}
-            </Button>
-          </div>
+          {process.env.showSmsMfa && (
+            <div className="text-center mt-6">
+              <Button
+                styleType={AppearanceStyleType.accentCool}
+                data-testid="verify-by-phone"
+                onClick={smsOnClick}
+              >
+                {t("nav.signInMFA.verifyByPhone")}
+              </Button>
+            </div>
+          )}
         </Form>
       </div>
     </FormCard>