Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #26: Fix splices in requires clause #86

Merged
merged 7 commits into from
Aug 12, 2024

Conversation

delimbetov
Copy link

Issue number of the reported bug or feature request: #26

Describe your changes
Fixed parsing of splices in requires clauses

Testing performed
Added tests for the 4 requirements types: simple, type, compound and nested.

Signed-off-by: delimbetov <1starfall1@gmail.com>
Signed-off-by: delimbetov <1starfall1@gmail.com>
Signed-off-by: delimbetov <1starfall1@gmail.com>
Signed-off-by: delimbetov <1starfall1@gmail.com>
Signed-off-by: delimbetov <1starfall1@gmail.com>
Signed-off-by: delimbetov <1starfall1@gmail.com>

# Conflicts:
#	P2996.md
@delimbetov delimbetov marked this pull request as ready for review August 8, 2024 19:22
Copy link
Collaborator

@katzdm katzdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing! Two very minor comment nits, and we're good to go.

clang/test/Reflection/splice-types.cpp Show resolved Hide resolved
static_assert(nested_addable2<Addable>);
static_assert(!nested_addable2<NonAddable>);

}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

}  // namespace requires_clause

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Signed-off-by: delimbetov <1starfall1@gmail.com>
@katzdm katzdm merged commit 058106a into bloomberg:p2996 Aug 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants