Address log delete races #4768
Open
Address log delete races #4768
+19
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morgan Douglas <mdouglas47@bloomberg.net>
Signed-off-by: Morgan Douglas <mdouglas47@bloomberg.net>
roborivers
suggested changes
Oct 15, 2024
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 7/584 tests failed ⚠.
The first 10 failing tests are:
timepart_constraints [setup failure]
verify_error_partial_index_off_generated [setup failure]
sc_remsql_fdbpushredirect_generated [setup failure]
analyze_partial_index_off_generated
commit_lsn_map_delete_generated
snap_ha_retry_newsi_generated
dbcreate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few places where the log deletion lock isn't held over
backend_update_sync. The changes in this PR update the implementation ofbackend_update_syncto acquire the lock for the duration of the call instead of requiring the caller to hold the lock.