-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature calculator return type documentation #1062
Labels
Comments
Very good observation @dilwong (and sorry for the late response). Would you like to do a PR to fix this (or at least some of them)? |
dilwong
added a commit
to dilwong/tsfresh
that referenced
this issue
Apr 21, 2024
Corrected docstrings of fctype=combiner feature calculators to have the correct return type.
Ok sure, I submitted PR #1070 for this. |
dilwong
added a commit
to dilwong/tsfresh
that referenced
this issue
Apr 22, 2024
… typing module notation.
nils-braun
pushed a commit
that referenced
this issue
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This isn't a bug, but more of a documentation issue. According to the docs, as well as in the docstrings for the functions in
tsfresh.feature_extraction.feature_calculators
, the documented return type for feature calculators offctype=combiner
appears to be incorrect. For example, seeagg_linear_trend
that claims to return a pandas Series, oraugmented_dickey_fuller
that claims to return afloat
.The text was updated successfully, but these errors were encountered: