Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #1062: Feature calculator return type documentation #1070

Merged
merged 4 commits into from
May 26, 2024
Merged

Issue #1062: Feature calculator return type documentation #1070

merged 4 commits into from
May 26, 2024

Conversation

dilwong
Copy link
Contributor

@dilwong dilwong commented Apr 21, 2024

Corrected docstrings of fctype=combiner feature calculators to have the correct return type.

Resolves #1062

@dilwong
Issue blue-yonder#1062: Feature calculator return type documentation
c2c8c91 
Corrected docstrings of fctype=combiner feature calculators to have the correct return type.
@dilwong dilwong mentioned this pull request Apr 21, 2024
Closed
nils-braun
nils-braun reviewed Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@nils-braun nils-braun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you maybe use Python typing notation for the types, like List[Tuple[str, bool]]? This will make them look nicer in the docs :)

@dilwong
Copy link
Contributor Author

dilwong commented Apr 22, 2024

Ok done.

nils-braun
nils-braun approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@nils-braun nils-braun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@nils-braun nils-braun enabled auto-merge (squash) April 22, 2024 20:19
@nils-braun nils-braun merged commit 3da2360 into blue-yonder:main May 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nils-braun nils-braun nils-braun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature calculator return type documentation
2 participants
@dilwong @nils-braun