-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extra notes on parallelization efficiencies #1046
Extra notes on parallelization efficiencies #1046
Conversation
Setting a few environment variables can greatly improve parallelization by removing over-provisioning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Appreciate your work! I had a few suggestions to make the text a bit easier to read (e.g. shorter sentences), but in general I am happy with this already
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1046 +/- ##
=======================================
Coverage 93.43% 93.43%
=======================================
Files 20 20
Lines 1888 1888
Branches 372 372
=======================================
Hits 1764 1764
Misses 85 85
Partials 39 39 ☔ View full report in Codecov by Sentry. |
Thanks @nils-braun , I agree with all those changes, much neater and concise . |
I have not submitted the comments for paragraph removal as "change suggestion" - so I think you need to do this manually - but maybe you can fix the code styling issues seen by the GitHub action in the same change? |
Co-authored-by: Nils Braun <nils-braun@users.noreply.github.com>
Co-authored-by: Nils Braun <nils-braun@users.noreply.github.com>
Co-authored-by: Nils Braun <nils-braun@users.noreply.github.com>
Co-authored-by: Nils Braun <nils-braun@users.noreply.github.com>
Co-authored-by: Nils Braun <nils-braun@users.noreply.github.com>
Co-authored-by: Nils Braun <nils-braun@users.noreply.github.com>
remove unnessary paragrpahs relating to over provisioning
ok, I have done the updates as suggested. I also added a link from the faq, which might be handy. I'll let you decide that though :-) |
Thanks @dom-white! Changes look good. I will fix the style check issues and then merge 👍 |
Setting a few environment variables can greatly improve parallelization by removing over-provisioning. I have updated the document section discussing parallelization to show how this can be achieved.