Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra notes on parallelization efficiencies #1046

Merged
merged 11 commits into from
Oct 24, 2023

Conversation

dom-white
Copy link
Contributor

Setting a few environment variables can greatly improve parallelization by removing over-provisioning. I have updated the document section discussing parallelization to show how this can be achieved.

Setting a few environment variables can greatly improve parallelization by removing over-provisioning
Copy link
Collaborator

@nils-braun nils-braun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Appreciate your work! I had a few suggestions to make the text a bit easier to read (e.g. shorter sentences), but in general I am happy with this already

docs/text/tsfresh_on_a_cluster.rst Outdated Show resolved Hide resolved
docs/text/tsfresh_on_a_cluster.rst Outdated Show resolved Hide resolved
docs/text/tsfresh_on_a_cluster.rst Outdated Show resolved Hide resolved
docs/text/tsfresh_on_a_cluster.rst Outdated Show resolved Hide resolved
docs/text/tsfresh_on_a_cluster.rst Outdated Show resolved Hide resolved
docs/text/tsfresh_on_a_cluster.rst Outdated Show resolved Hide resolved
docs/text/tsfresh_on_a_cluster.rst Outdated Show resolved Hide resolved
docs/text/tsfresh_on_a_cluster.rst Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f3a6a7c) 93.43% compared to head (ae93811) 93.43%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1046   +/-   ##
=======================================
  Coverage   93.43%   93.43%           
=======================================
  Files          20       20           
  Lines        1888     1888           
  Branches      372      372           
=======================================
  Hits         1764     1764           
  Misses         85       85           
  Partials       39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dom-white
Copy link
Contributor Author

Thanks @nils-braun , I agree with all those changes, much neater and concise .
I'm a bit rusty on github, what is the neatest way to apply all those changes to the pull request. I see I can accept the edits you made, but not for the comments relating to paragraph removal.

@nils-braun
Copy link
Collaborator

I have not submitted the comments for paragraph removal as "change suggestion" - so I think you need to do this manually - but maybe you can fix the code styling issues seen by the GitHub action in the same change?
Thank you! :-)

dom-white and others added 8 commits October 2, 2023 09:19
Co-authored-by: Nils Braun <nils-braun@users.noreply.github.com>
Co-authored-by: Nils Braun <nils-braun@users.noreply.github.com>
Co-authored-by: Nils Braun <nils-braun@users.noreply.github.com>
Co-authored-by: Nils Braun <nils-braun@users.noreply.github.com>
Co-authored-by: Nils Braun <nils-braun@users.noreply.github.com>
Co-authored-by: Nils Braun <nils-braun@users.noreply.github.com>
remove unnessary paragrpahs relating to over provisioning
@dom-white
Copy link
Contributor Author

ok, I have done the updates as suggested. I also added a link from the faq, which might be handy. I'll let you decide that though :-)

@nils-braun
Copy link
Collaborator

Thanks @dom-white! Changes look good. I will fix the style check issues and then merge 👍

@nils-braun nils-braun merged commit e2dfc6f into blue-yonder:main Oct 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants