Core: Frontend: ExtensionmanagerView: Allow users to download streamed ext logs as files #2963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allows users to download streamed logs from ext as files, even when container is reconnecting small pieces of logs that it was able to stream will be at the file
JoaoMario109
force-pushed
the
add-download-ext-log-as-file
branch
from
ac25ab4
to
e95e785
Compare
JoaoMario109
requested review from
Williangalvani,
joaoantoniocardoso and
patrickelectric
Williangalvani
approved these changes
Oct 17, 2024
|
woohoo! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now its download directly from buffer generated on frontend, this will include cases where extension is restarting and just able to send small pieces of data.
Closes #2962