-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor feeGrowthInsideLastX128
#74
Conversation
feeGrowthInsideLastX128
Methods
Deployments
Solidity and Network Config
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
|
Slither reportTHIS CHECKLIST IS NOT COMPLETE. Use
unused-returnImpact: Medium
BNBParty.Factory/contracts/BNBPartyLiquidity.sol Lines 14 to 56 in 57bbfb3
BNBParty.Factory/contracts/BNBPartyFee.sol Lines 118 to 130 in 57bbfb3
BNBParty.Factory/contracts/BNBPartyLiquidityHelper.sol Lines 16 to 40 in 57bbfb3
BNBParty.Factory/contracts/BNBPartyFee.sol Lines 31 to 43 in 57bbfb3
BNBParty.Factory/contracts/BNBPartyCreation.sol Lines 43 to 77 in 57bbfb3
BNBParty.Factory/contracts/BNBPartySwaps.sol Lines 47 to 53 in 57bbfb3
reentrancy-benignImpact: Low
BNBParty.Factory/contracts/BNBPartyLiquidity.sol Lines 14 to 56 in 57bbfb3
reentrancy-eventsImpact: Low
BNBParty.Factory/contracts/BNBPartySwaps.sol Lines 13 to 22 in 57bbfb3
BNBParty.Factory/contracts/BNBPartySwaps.sol Lines 13 to 22 in 57bbfb3
BNBParty.Factory/contracts/BNBPartySwaps.sol Lines 13 to 22 in 57bbfb3
BNBParty.Factory/contracts/BNBPartyLiquidity.sol Lines 14 to 56 in 57bbfb3
naming-conventionImpact: Informational
reentrancy-unlimited-gasImpact: Informational
BNBParty.Factory/contracts/BNBPartySwaps.sol Lines 13 to 22 in 57bbfb3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take another look here - some thing not 100% - not sure what
closes #68