Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing yolo v3 #10

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Implementing yolo v3 #10

wants to merge 8 commits into from

Conversation

georoen
Copy link

@georoen georoen commented Dec 28, 2018

This PR proposes an updated engine for image.darknet. It:

What I did is practically:

  1. clone pjreddie/darknet into inst/include/
  2. copy inst/include/darknet/src into src/
  3. "debugged" some files in src/ by looking at inst/include/darknet/examples/detector.c

The last step however involved changing some pointers. As I may be into R packages, I am new to C and have some questions why. Sometimes I had to just add an &, some other times I had to change &net.w to net->w? Long story short, it would be cool if you take a particular look at the changes in src/__R_API_detector.c, src/__R_API_classifier.c and src/compare.c, before merging.

Best wishes!

@georoen georoen changed the title Implementing yolov3 Implementing yolo v3 Dec 28, 2018
@jwijffels
Copy link
Contributor

nice effort and a lot of code changes! if this is the first time you start using C with R you probably took a difficult project :)
-> is for accessing object elements and methods of a pointer

Some questions

  • do you also know if pjreddies darknet yolo is now also working fine on windows? of should we use the windows compatible fork
  • on which platform did you test it out
  • do you know if trained models of yolov2 are compatible with yolov3

@georoen
Copy link
Author

georoen commented Dec 29, 2018

I'm aware of the scope of this project. So I started slowly by cloning @pjreddie's code, see commit 0255d3c and 372151c, and myself only edited the three C files noted above.

  • I do not know about Windows. Will have to try inside a VM.
  • I build and tested this image.darknet version on Ubuntu 16.04 and 18.04, both R Version 3.5.2.
  • yolov2 works fine, just download the yolov2.weights into system.file(package="image.darknet", "models", "yolov2.weights").

@georoen
Copy link
Author

georoen commented Jan 7, 2019

Hi @jwijffels, I just checked Windows compatibility today. Both, your and my updated version of image.darknet work on Windows 7 with R 3.5.1, Rtools 3.5 and devtools 2.0.1 installed.

@jwijffels
Copy link
Contributor

Hi @georoen
I'll start checking this beginning of february

@georoen
Copy link
Author

georoen commented May 20, 2019

Hi @jwijffels
How are you doing? Will latest YOLO be implemented soon?
Best, Jeroen

@jwijffels
Copy link
Contributor

Had to skip this for the time being due to other priorities. Is there already a yolo v4?

@georoen
Copy link
Author

georoen commented Aug 6, 2019

Hi @jwijffels,
sorry for the late responds - this time it was me having other priorities...

Nevertheless, meanwhile there were no changes in the official YOLO repo or website and I guess my pull request is still up to date from this aspect.
The other aspect is. that, you will need to merge this PR with your commit #ab7c47a on 6 Feb.

Let me know how it goes.
Very best,
Jeroen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants