-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generating CPU Profile Flame Graph #144
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
I understand that this is a draft, but I have made a few comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a binary file of the benchmark output, so could you please exclude it from this pull request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please exclude this note from the pull request?
@@ -176,6 +177,39 @@ func TestHalt(t *testing.T) { | |||
} | |||
} | |||
|
|||
func BenchmarkNewAndLoadLinuxWithBZimage(b *testing.B) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please take a look at the Travis CI message and fix?
The message is mainly from linter.
https://app.travis-ci.com/github/bobuhiro11/gokvm/jobs/600467277
First attempt at generating a flamegraph of cpu data when running gokvm
To see flamegraph and process tree visualization run
go tool pprof -http=:8080 example-cpu.prof
Under the pprof view menu, there are different options for visualizing the data including a flamegraph