Fe/feature/#560 error boundary적용 #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
기존 이름은 root에 해당하는 라우터로 착각할 수 있기에 변경함
Deploying with
|
| Latest commit: |
3900cfa
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://765a5dac.web09-magicconch.pages.dev |
| Branch Preview URL: | https://fe-feature--560-errorboundar.web09-magicconch.pages.dev |
kimyu0218
approved these changes
Feb 26, 2024
| @@ -21,6 +21,7 @@ | |||
| "html2canvas": "^1.4.1", | |||
| "react": "^18.2.0", | |||
| "react-dom": "^18.2.0", | |||
| "react-error-boundary": "^4.0.12", | |||
Comment on lines
+33
to
+41
| this.socket?.on('disconnect', () => { | ||
| alert('서버와 연결이 끊겼습니다. 메인 페이지로 이동합니다.'); | ||
| window.location.href = '/'; | ||
| }); | ||
|
|
||
| this.socket?.on('connect_error', () => { | ||
| alert('서버와 연결할 수 없습니다. 메인 페이지로 이동합니다.'); | ||
| window.location.href = '/'; | ||
| }); |
HeoJiye
approved these changes
Feb 26, 2024
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔮 resolved #560
변경 사항
고민과 해결 과정
Note
API에서 발생하는 에러에 대해서 APIErrorBoundary안에서 처리 해줘야함
<UnknownErrorBoundary>에서 처리나중에 센트리를 적용해 미처 생각치 못한 알수없는 에러 발생시 센트리로 보내주면 좋을듯
(선택) 테스트 결과
ex) 베이스 브랜치에 포함되기 위한 코드는 모두 정상적으로 동작해야 합니다. 결과물에 대한 스크린샷, GIF, 혹은 라이브 데모가 가능하도록 샘플API를 첨부할 수도 있습니다.