Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for fixed width 128-bit float with specified precision #232

Merged
merged 26 commits into from
Oct 28, 2024

Conversation

mborland
Copy link
Member

Also updates the codecov runner to GCC-13 and includes GNU runs so that we can get coverage of the <stdfloat> paths.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 99.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.76%. Comparing base (e875722) to head (8cdcb5e).
Report is 29 commits behind head on develop.

Files with missing lines Patch % Lines
...lude/boost/charconv/detail/ryu/ryu_generic_128.hpp 97.14% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #232      +/-   ##
===========================================
+ Coverage    94.63%   94.76%   +0.12%     
===========================================
  Files           67       69       +2     
  Lines         8673     9031     +358     
===========================================
+ Hits          8208     8558     +350     
- Misses         465      473       +8     
Files with missing lines Coverage Δ
src/to_chars.cpp 92.94% <ø> (-0.95%) ⬇️
test/github_issue_166_float128.cpp 100.00% <100.00%> (ø)
test/to_chars_float_STL_comp.cpp 100.00% <100.00%> (ø)
...lude/boost/charconv/detail/ryu/ryu_generic_128.hpp 92.72% <97.14%> (+4.86%) ⬆️

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e875722...8cdcb5e. Read the comment docs.

@mborland mborland linked an issue Oct 28, 2024 that may be closed by this pull request
@mborland mborland merged commit abb721d into develop Oct 28, 2024
70 checks passed
@mborland mborland deleted the float128 branch October 28, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant