Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU Batch 13 #1201

Merged
merged 3 commits into from
Sep 19, 2024
Merged

GPU Batch 13 #1201

merged 3 commits into from
Sep 19, 2024

Conversation

mborland
Copy link
Member

This PR resumes work on special functions and adds support for: expint, gegenbauer, gegenbauer_prime, gegenbauer_derivative, cyl_hankel_1, cyl_hankel_2, sph_hankel_1, sph_hankel_2, and hermite.

In the docs I added a note that states in the NVCC or NVRTC case the return type of cyl and sph hankels is in namespace cuda::std:: instead of std:: so you get a cuda::std::complex<T> as the result. Much like other utilities developed so far boost::math::complex<T> is just an alias to the proper type depending on context.

On device CI runs can be found: cppalliance/cuda-math#27

CC: @dschmitz89, @izaid, @steppi

Add SYCL testing of expint

Add markers to forward decls

Add CUDA testing of expint

Fix static variable usage under NVRTC

Add NVRTC testing

Add configurable definition of complex

Add function aliases

Add GPU support to gegenbauer polynomials

Add SYCL testing of gegenbauer

Add NVCC testing of gegenbauer

Add NVRTC testing of gegenbauer

Add GPU support for hankel

Add SYCL testing of hankel

Add NVCC testing of cyl_hankel_1

Add comprehensive NVCC testing

Add NVRTC testing of cyl and sph hankel

Update docs

Fix writing cuda::std::complex<T> to stdout

Add GPU support to hermite

Add SYCL testing of hermite

Add CUDA testing of hermite

Add NVRTC testing of hermite

Add markers to hermite docs
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 96.55172% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.78%. Comparing base (c3afa49) to head (9f21419).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
include/boost/math/special_functions/hankel.hpp 92.59% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1201   +/-   ##
========================================
  Coverage    93.78%   93.78%           
========================================
  Files          657      657           
  Lines        53899    53903    +4     
========================================
+ Hits         50551    50555    +4     
  Misses        3348     3348           
Files with missing lines Coverage Δ
include/boost/math/special_functions/bessel.hpp 100.00% <ø> (ø)
include/boost/math/special_functions/expint.hpp 95.41% <100.00%> (+0.06%) ⬆️
include/boost/math/special_functions/hermite.hpp 100.00% <100.00%> (ø)
test/test_expint.cpp 100.00% <ø> (ø)
test/test_expint.hpp 100.00% <ø> (ø)
test/test_hankel.cpp 100.00% <ø> (ø)
test/test_hermite.cpp 93.75% <ø> (ø)
test/test_hermite.hpp 100.00% <ø> (ø)
include/boost/math/special_functions/hankel.hpp 94.11% <92.59%> (+0.11%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3afa49...9f21419. Read the comment docs.

@mborland mborland merged commit ad68aee into develop Sep 19, 2024
79 checks passed
@mborland mborland deleted the GPU_batch_13 branch September 19, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant