Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance CI for more coverage #55

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jeking3
Copy link
Contributor

@jeking3 jeking3 commented Apr 29, 2018

No description provided.

@jeking3 jeking3 force-pushed the workaround-ubsan-issue-on-travis branch from b0f5711 to 9a96f6b Compare October 28, 2018 02:30
@jeking3 jeking3 changed the title Work around a new travis ubsan issue with gcc 7.3 Enhance CI for more coverage Oct 28, 2018
@jeking3
Copy link
Contributor Author

jeking3 commented Oct 28, 2018

Interesting gcc 4.4 failure with expanded coverage

/usr/include/c++/4.4/bits/shared_ptr.h:1005: error: cannot use typeid with -fno-rtti
    "g++-4.4"   -std=c++0x -fvisibility-inlines-hidden -fno-rtti -m64 -O0 -fno-inline -Wall -g -fvisibility=hidden  -DBOOST_ALL_NO_LIB=1 -DBOOST_NO_RTTI -DBOOST_NO_TYPEID  -I"../.." -c -o "../../bin.v2/libs/program_options/test/options_description_no_rtti_test.test/gcc-4.4/debug/cxxstd-0x-iso/link-static/rtti-off/visibility-hidden/options_description_test.o" "../../libs/program_options/test/options_description_test.cpp"
...failed gcc.compile.c++ ../../bin.v2/libs/program_options/test/options_description_no_rtti_test.test/gcc-4.4/debug/cxxstd-0x-iso/link-static/rtti-

Probably need to drop gcc 4.4 from the list of compilers tested in expanded CI based on this...

@jeking3 jeking3 force-pushed the workaround-ubsan-issue-on-travis branch from 9a96f6b to baff9b1 Compare October 30, 2018 00:18
@jeking3 jeking3 force-pushed the workaround-ubsan-issue-on-travis branch from baff9b1 to 5cdb92e Compare February 27, 2019 13:50
@codecov
Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #55 into develop will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #55      +/-   ##
===========================================
+ Coverage    49.89%   49.96%   +0.07%     
===========================================
  Files           23       23              
  Lines         1385     1385              
  Branches       707      707              
===========================================
+ Hits           691      692       +1     
  Misses         110      110              
+ Partials       584      583       -1
Impacted Files Coverage Δ
...de/boost/program_options/detail/value_semantic.hpp 43.75% <0%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d95d316...5cdb92e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant