Merge pull request #851 from bartsanchez/bart/fix-ruff-rule-PLR1704

fix: Ruff rule PLR1704 (redefined-argument-from-local)

pyproject.toml

@@ -105,12 +105,31 @@ line-length = 120
 target-version = "py310"
 
 [tool.ruff.lint]
-select = ["E", "F", "I", "C4", "UP", "RUF"]
+select = [
+    "C4",
+    "E",
+    "F",
+    "I",
+    "PLR",
+    "RUF",
+    "UP",
+]
 ignore = [
     "E713",
     "E722",
     "E731",
     "E741",
+    "PLR0124",
+    "PLR0402",
+    "PLR0911",
+    "PLR0912",
+    "PLR0913",
+    "PLR0915",
+    "PLR1714",
+    "PLR1722",
+    "PLR1730",
+    "PLR2004",
+    "PLR5501",
     "RUF005",
     "RUF012",
     "RUF013",

src/api/symboltable/symboltable.py

@@ -83,9 +83,9 @@ def get_entry(self, id_: str, scope: Scope | None = None) -> symbols.ID | None:
         if scope is not None:
             return scope[id_]
 
-        for scope in self:
-            if scope[id_] is not None:
-                return scope[id_]
+        for s in self:
+            if s[id_] is not None:
+                return s[id_]
 
         return None  # Not found
 

src/arch/z80/backend/_f16.py

@@ -195,9 +195,9 @@ def f16_to_32bit(cls, ins: Quad) -> Quad:
         as they are.
         """
         quads = list(ins)
-        for i, ins in enumerate(quads[1:], 1):
-            if is_float(ins):
-                de, hl = cls.f16(ins)
+        for i, instruction in enumerate(quads[1:], 1):
+            if is_float(instruction):
+                de, hl = cls.f16(instruction)
                 quads[i] = str((de << 16) | hl)
 
         ins = Quad(*quads)