fix: mypy "has-type" check #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boriel
reviewed
Oct 28, 2024
src/arch/z80/peephole/evaluator.py
Outdated
| @@ -106,7 +106,7 @@ class Number: | |||
|
|
|||
| def __init__(self, value): | |||
| if isinstance(value, Number): | |||
| self.value = value.value | |||
| self.value: Any = value.value | |||
There was a problem hiding this comment.
Should be:
self.value: int | None = value.valueThere was a problem hiding this comment.
Great, changed!
boriel
reviewed
Oct 28, 2024
src/arch/z80/optimizer/basicblock.py
Outdated
| @@ -440,7 +440,7 @@ def optimize(self, patterns_list): | |||
| "c": str(self.cpu.C) if self.cpu.C is not None else new_tmp_val(), | |||
| "z": str(self.cpu.Z) if self.cpu.Z is not None else new_tmp_val(), | |||
| }.get(x.lower(), new_tmp_val()) | |||
| evaluator.UNARY[FN.IS_REQUIRED] = lambda x: self.is_used([x], i + len(p.patt)) | |||
| evaluator.UNARY[FN.IS_REQUIRED] = lambda x: self.is_used([x], i + len(p.patt)) # type: ignore[has-type] | |||
There was a problem hiding this comment.
Here i is int and p is of type OptPattern.
Suggestion:
- add
from src.arch.z80.peephole.engine import OptPatternat the beginning of the file. - change the function signature to:
def optimize(self, patterns_list: Sequence[OptPattern]) -> None: - Add these to lines below the function header:
i: int
p: OptPattern
This way we can get rid of the # type: ignore line 😉
There was a problem hiding this comment.
Added the variables below the function header.
boriel
requested changes
Oct 28, 2024
bartsanchez
force-pushed
the
bart/fix-has-type-mypy
branch
from
d92597c
to
678592c
Compare
bartsanchez
force-pushed
the
bart/fix-has-type-mypy
branch
from
678592c
to
a1fb678
Compare
boriel
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.