feat(popup-v2): gate rich text on feature flag - #771
Draft
jmcbgaston wants to merge 1 commit into
Draft
Conversation
|
|
jmcbgaston
marked this pull request as ready for review
August 28, 2026 04:00
Hosts pass isRichTextEnabled so the popup can share markdown authoring with sidebar comments without changing the default plain-text mention path.
jmcbgaston
force-pushed
the
enable-popup-rich-text
branch
from
August 28, 2026 04:03
e097525 to
8e5954d
Compare
Author
|
TODO / blocker: this PR depends on unpublished Do not merge until that publish lands. |
jmcbgaston
marked this pull request as draft
August 28, 2026 16:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
features.isRichTextEnabledis true, the annotation popup forwards that flag toThreadedAnnotationsV2andMessageEditorV2, serializes create/reply/edit payloads withserializeMessageToMarkdown, and parses stored bodies withparseMessageMarkdown. When the flag is absent or false, posts and views still use mention-markup serialize/deserialize. Adapter helpers default the flag to false so existing callers stay on that path.