fix: resolve keytar directory in postinstall script - #713
Merged
Conversation
Use require.resolve to locate @github/keytar instead of a hardcoded node_modules path, so the build directory is removed reliably across install layouts. Co-authored-by: Cursor <cursoragent@cursor.com>
congminh1254
changed the title
postinstall script
congminh1254
changed the title
postinstall scriptkeytar directory in postinstall script
Coverage Report for CI Build 33076266001Coverage increased (+0.03%) to 84.939%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
mwwoda
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node_modules/@github/keytar/buildpath inpostinstall.jswithrequire.resolve('@github/keytar/package.json')to locate the installed package directorysecure-storage.jsand tests, so the stalebuild/directory is removed reliably across hoisted or nested install layoutsTest plan
node ./src/postinstall.jslocally — exits successfullynpm installon a fresh checkout and confirm postinstall completes without errorMade with Cursor