Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split: more strict #673

Merged
merged 1 commit into from
Jul 19, 2024
Merged

split: more strict #673

merged 1 commit into from
Jul 19, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jul 19, 2024

  • Strict was disabled in function nextfile() but this masked that the program depends on a few global variables
  • Declare the variables explicitly; FH becomes $Fh to avoid aliasing the name $fh which is used later on
  • The benefit of the "package" declaration in nextfile() is unclear to me

@mknos
split: more strict
43f7a9e 
* Strict was disabled in function nextfile() but this masked that the program depends on a few global variables
* Declare the variables explicitly; FH becomes $Fh to avoid aliasing the name $fh which is used later on
* The benefit of the "package" declaration in nextfile() is unclear to me
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: split The split program labels Jul 19, 2024
@mknos mknos temporarily deployed to automated_testing July 19, 2024 12:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 19, 2024 12:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 19, 2024 12:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 19, 2024 12:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 19, 2024 12:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 19, 2024 12:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 19, 2024 12:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 19, 2024 12:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 19, 2024 12:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 19, 2024 12:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 19, 2024 12:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 19, 2024 12:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 19, 2024 12:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 19, 2024 12:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 19, 2024 12:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 19, 2024 12:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 19, 2024 12:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 19, 2024 12:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 19, 2024 12:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 19, 2024 12:12 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Jul 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10007819779

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.7%) to 76.268%
Files with Coverage Reduction New Missed Lines %
bin/units 3 71.21%
Totals Coverage Status
Change from base Build 10004906528: -0.7%
Covered Lines: 376
Relevant Lines: 493
💛 - Coveralls

@briandfoy briandfoy merged commit cfc23fa into briandfoy:master Jul 19, 2024
22 of 23 checks passed
@briandfoy briandfoy self-assigned this Jul 19, 2024
@briandfoy briandfoy added the Status: accepted The fix is accepted label Jul 19, 2024
@briandfoy briandfoy added Type: modernization updating programs to current practices and removed Type: enhancement improve a feature that already exists Priority: low get to this whenever labels Jul 19, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: split The split program Status: released there is a new release with this fix Type: modernization updating programs to current practices
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy