Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ar: simplify strmode() #676

Merged
merged 1 commit into from
Jul 22, 2024
Merged

ar: simplify strmode() #676

merged 1 commit into from
Jul 22, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jul 22, 2024

  • When listing archive file contents with "perl ar -tv file.a", the -v flag enables printing the file permissions for each archive member
  • Take advantage of the $mode param being an octal string
  • As before, only take the last 3 octal digits and deal with trailing spaces in $mode param
  • By inspecting the 3 octal digits separately, there's no need for a modemap table to interpret the bits at the various positions for user/owner, group and other
  • Patch tested against a file created by this ar, and another file created by binutils
%perl ar -q test.a words wordlist.txt.old
%perl ar -tv test.a
rwxr-xr-x    1000/1000       3975 Jun 12 09:13 2024 words
rw-r--r--    1000/1000         23 Feb  7 13:00 2024 wordlist.txt.old

@mknos
ar: simplify strmode()
084e1d8 
* When listing archive file contents with "perl ar -tv file.a", the -v flag enables printing the file permissions for each archive member
* Take advantage of the $mode param being an octal string
* As before, only take the last 3 octal digits and deal with trailing spaces in $mode param
* By inspecting the 3 octal digits separately, there's no need for a modemap table to interpret the bits at the various positions for user/owner, group and other
* Patch tested against a file created by this ar, and another file created by binutils
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ar The ar program labels Jul 22, 2024
@mknos mknos temporarily deployed to automated_testing July 22, 2024 01:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 22, 2024 01:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 22, 2024 01:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 22, 2024 01:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 22, 2024 01:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 22, 2024 01:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 22, 2024 01:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 22, 2024 01:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 22, 2024 01:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 22, 2024 01:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 22, 2024 01:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 22, 2024 01:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 22, 2024 01:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 22, 2024 01:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 22, 2024 01:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 22, 2024 01:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 22, 2024 01:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 22, 2024 01:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 22, 2024 01:42 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 22, 2024 01:43 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Jul 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10033213409

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 76.268%
Totals Coverage Status
Change from base Build 10026365693: -0.7%
Covered Lines: 376
Relevant Lines: 493
💛 - Coveralls

@briandfoy briandfoy self-assigned this Jul 22, 2024
@briandfoy briandfoy merged commit df5bc6f into briandfoy:master Jul 22, 2024
22 of 23 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jul 22, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ar The ar program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy