Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cp: warn on File::Copy::copy() failure #680

Merged
merged 1 commit into from
Jul 24, 2024
Merged

cp: warn on File::Copy::copy() failure #680

merged 1 commit into from
Jul 24, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jul 24, 2024

  • When cp runs in non-unix mode, take advantage of File::Copy::copy() setting $! on failure
  • When the destination was a non-existent directory, cp would do exit(1) but did not show the reason for failure

@mknos
cp: warn on File::Copy::copy() failure
049b78f 
* When cp runs in non-unix mode, take advantage of File::Copy::copy() setting $! on failure
* When the destination was a non-existent directory, cp would do exit(1) but did not show the reason for failure
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: cp The cp command labels Jul 24, 2024
@mknos mknos temporarily deployed to automated_testing July 24, 2024 01:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 24, 2024 01:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 24, 2024 01:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 24, 2024 01:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 24, 2024 01:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 24, 2024 01:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 24, 2024 01:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 24, 2024 01:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 24, 2024 01:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 24, 2024 01:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 24, 2024 01:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 24, 2024 01:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 24, 2024 01:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 24, 2024 01:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 24, 2024 01:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 24, 2024 01:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 24, 2024 01:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 24, 2024 01:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 24, 2024 01:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 24, 2024 01:04 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Jul 24, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10068691881

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 76.268%
Totals Coverage Status
Change from base Build 10060475186: -0.7%
Covered Lines: 376
Relevant Lines: 493
💛 - Coveralls

briandfoy
briandfoy approved these changes Jul 24, 2024
View reviewed changes
Copy link
Owner

@briandfoy briandfoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I like that you are cleaning up these long range things.

@briandfoy briandfoy merged commit 4fcd7ed into briandfoy:master Jul 24, 2024
22 of 23 checks passed
@briandfoy briandfoy self-assigned this Jul 24, 2024
@briandfoy briandfoy added the Status: accepted The fix is accepted label Jul 24, 2024
@briandfoy briandfoy removed the Priority: low get to this whenever label Jul 24, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: cp The cp command Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy