Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tee: add strict #684

Merged
merged 1 commit into from
Jul 28, 2024
Merged

tee: add strict #684

merged 1 commit into from
Jul 28, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jul 27, 2024

  • Correct left-over reference to variable $unbuffer
  • Remove custom SIGPIPE code which doesn't exist in the BSD version (the only reference to signals is SIGINT being ignored)
  • Standards document mentions nothing about SIGPIPE in Asynchronous Events section[1]
  • Output files table (%fh) is now keyed based on file descriptor and contains filehandle and the saved filename from ARGV
  • Explicitly check for directory before opening a file
  • test1: "ifconfig | perl tee out.1" --> out.1 created
  • test2: "ifconfig | perl tee -a out.1 out.2" --> existing out.1 appended, out.2 created
  1. https://pubs.opengroup.org/onlinepubs/009696699/utilities/tee.html

@mknos
tee: add strict
e75c8f8 
* Correct left-over reference to variable $unbuffer
* Remove custom SIGPIPE code which doesn't exist in the BSD version (the only reference to signals is SIGINT being ignored)
* Standards document mentions nothing about SIGPIPE in Asynchronous Events section[1]
* Output files table (%fh) is now keyed based on file descriptor and contains filehandle and the saved filename from ARGV
* Explicitly check for directory before opening a file
* test1: "ifconfig | perl tee out.1" --> out.1 created
* test2: "ifconfig | perl tee -a out.1 out.2" --> existing out.1 appended, out.2 created

1. https://pubs.opengroup.org/onlinepubs/009696699/utilities/tee.html
@mknos mknos temporarily deployed to automated_testing July 27, 2024 14:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 27, 2024 14:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 27, 2024 14:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 27, 2024 14:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 27, 2024 14:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 27, 2024 14:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 27, 2024 14:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 27, 2024 14:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 27, 2024 14:12 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: tee The tee program labels Jul 27, 2024
@mknos mknos temporarily deployed to automated_testing July 27, 2024 14:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 27, 2024 14:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 27, 2024 14:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 27, 2024 14:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 27, 2024 14:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 27, 2024 14:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 27, 2024 14:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 27, 2024 14:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 27, 2024 14:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 27, 2024 14:12 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 27, 2024 14:13 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Jul 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10124145789

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 76.268%
Totals Coverage Status
Change from base Build 10118477474: -0.7%
Covered Lines: 376
Relevant Lines: 493
💛 - Coveralls

@briandfoy briandfoy merged commit fa32a1e into briandfoy:master Jul 28, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

I think the SIGPIPE thing was a joke.

@briandfoy briandfoy added the Status: accepted The fix is accepted label Aug 5, 2024
@briandfoy briandfoy removed the Priority: low get to this whenever label Aug 5, 2024
@briandfoy briandfoy self-assigned this Aug 12, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: tee The tee program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy