Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TW20830473 Updating to version 4.4. #6

Merged
merged 27 commits into from
May 30, 2024
Merged

TW20830473 Updating to version 4.4. #6

merged 27 commits into from
May 30, 2024

Conversation

mchurchward
Copy link
Contributor

No description provided.

lucaboesch and others added 27 commits May 30, 2024 14:12
- moodle-cs 3.4.1
- moodle-local_moodlecheck 1.3.0
- moodle-local_ci 1.0.28
- php-compatibility e5cd2e24

It also comes with a good number of updates in
dev tools and other dependencies.

Note that we have had to stay sticky to vimeo/psalm 5.19.*
because 5.20 comes with some new RiskyTruthyFalsyComparison
problems that we need to analyse. This issue has been created
about that: moodlehq/moodle-plugin-ci#279
Better stop having the deprecated phpcpd command available
in the dist and explain docs, so newcomers won't enable it
by default. It's going to be removed in v5.

Part of #262, credit goes to @jrchamp
A new `license-regex` option has been added to the phpcs command.

It allows to specify the regex that will be used when inspecting
@license tags.

By default, an empty string is used for the option and that makes
the Sniff to stop checking. Whoever wants to check for anything
can use the new option to configure it.
- moodle-cs 3.3.4
- moodle-local_ci 1.0.29
- moodle-local_moodlecheck 1.3.2

Also some other dependencies and tools updates.
- moodle-cs 3.4.5
- moodle-cs - 3.4.6
This includes both the current default (when neither pcov or
xdebug are available) and the explicit use of --coverage-phpdbg

Since PHP 8.0, phpdbg is causing all sort of problems and is
not recommended. So it's time to deprecate it in order to
proceed to remove it completely for moodle-plugin-ci 5.0.0.

Removal ref.: moodlehq/moodle-plugin-ci#289

Fixes #213
@mchurchward mchurchward merged commit 5a9c870 into MOODLE_4 May 30, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants