Skip to content

Commit

Permalink
Update feedback page and rename to contact page
Browse files Browse the repository at this point in the history
  • Loading branch information
rileyhgrant committed Jul 17, 2023
1 parent 0b2ff28 commit 24835e9
Show file tree
Hide file tree
Showing 7 changed files with 40 additions and 22 deletions.
4 changes: 2 additions & 2 deletions browser/cypress/e2e/nav_bar_pages.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ describe('Home Page', () => {
pageHeader: 'publications from the gnomAD group',
},
{
pageTitle: 'Feedback',
pageUrl: '/feedback',
pageTitle: 'Contact',
pageUrl: '/contact',
pageHeader: 'Tell us how you use gnomAD',
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ import 'jest-styled-components'
import React from 'react'
import renderer from 'react-test-renderer'

import FeedbackPage from './FeedbackPage'
import ContactPage from './ContactPage'

import { withDummyRouter } from '../../tests/__helpers__/router'

test('Feedback Page has no unexpected changes', () => {
const tree = renderer.create(withDummyRouter(<FeedbackPage />))
test('Contact Page has no unexpected changes', () => {
const tree = renderer.create(withDummyRouter(<ContactPage />))
expect(tree).toMatchSnapshot()
})
20 changes: 16 additions & 4 deletions browser/src/FeedbackPage.tsx → browser/src/ContactPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ import InfoPage from './InfoPage'

export default () => (
<InfoPage>
<DocumentTitle title="Feedback" />
<PageHeading>Feedback</PageHeading>
<DocumentTitle title="Contact" />
<PageHeading>Contact</PageHeading>

<p>
Tell us how you use gnomAD and your wish list by filling out{' '}
Expand All @@ -27,9 +27,21 @@ export default () => (
{/* @ts-expect-error TS(2786) FIXME: 'ExternalLink' cannot be used as a JSX component. */}
<ExternalLink href="https://github.com/broadinstitute/gnomad-browser/issues">
GitHub
</ExternalLink>{' '}
</ExternalLink>
.
</p>

<p>
For questions about gnomAD, check out the{' '}
{/* @ts-expect-error TS(2786) FIXME: 'ExternalLink' cannot be used as a JSX component. */}
or by <ExternalLink href="mailto:gnomad@broadinstitute.org">email</ExternalLink>.
<ExternalLink href="/help">help page</ExternalLink>.
</p>

<p>
Note that, for many reasons (including consent and data usage restrictions), we do not have
(and cannot share) phenotype information. Overall, we have limited information that we can
share for some cohorts, such as last known age in bins of 5 years (when known) and chromosomal
sex.
</p>

<p>
Expand Down
4 changes: 2 additions & 2 deletions browser/src/NavBar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,8 @@ const NavBar = () => {
</Link>
</li>
<li>
<Link to="/feedback" onClick={closeMenu}>
Feedback
<Link to="/contact" onClick={closeMenu}>
Contact
</Link>
</li>
<li>
Expand Down
10 changes: 5 additions & 5 deletions browser/src/Routes.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import DocumentTitle from './DocumentTitle'
// Content pages
const AboutPage = lazy(() => import('./AboutPage'))
const TeamPage = lazy(() => import('./TeamPage/TeamPage'))
const FeedbackPage = lazy(() => import('./FeedbackPage'))
const ContactPage = lazy(() => import('./ContactPage'))
const DownloadsPage = lazy(() => import('./DownloadsPage/DownloadsPage'))
const HelpPage = lazy(() => import('./help/HelpPage'))
const HelpTopicPage = lazy(() => import('./help/HelpTopicPage'))
Expand All @@ -26,8 +26,8 @@ const VariantPageRouter = lazy(() => import('./VariantPageRouter'))

const ShortTandemRepeatPage = lazy(() => import('./ShortTandemRepeatPage/ShortTandemRepeatPage'))
const ShortTandemRepeatsPage = lazy(() => import('./ShortTandemRepeatsPage/ShortTandemRepeatsPage'))
const VariantCooccurrencePage = lazy(() =>
import('./VariantCooccurrencePage/VariantCooccurrencePage')
const VariantCooccurrencePage = lazy(
() => import('./VariantCooccurrencePage/VariantCooccurrencePage')
)

// Other pages
Expand Down Expand Up @@ -161,9 +161,9 @@ const Routes = () => {

<Route exact path="/publications" component={PublicationsPage} />

<Route exact path="/feedback" component={FeedbackPage} />
<Route exact path="/contact" component={ContactPage} />

<Route exact path="/contact" render={() => <Redirect to="/feedback" />} />
<Route exact path="/feedback" render={() => <Redirect to="/contact" />} />

<Route exact path="/mou" component={MOUPage} />

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`Feedback Page has no unexpected changes 1`] = `
exports[`Contact Page has no unexpected changes 1`] = `
.c3 {
color: #1173bb;
-webkit-text-decoration: none;
Expand Down Expand Up @@ -96,7 +96,7 @@ exports[`Feedback Page has no unexpected changes 1`] = `
<h1
className="c2"
>
Feedback
Contact
</h1>
</div>
<p>
Expand Down Expand Up @@ -136,18 +136,24 @@ exports[`Feedback Page has no unexpected changes 1`] = `
>
GitHub
</a>
.
</p>
<p>
For questions about gnomAD, check out the
or by
<a
className="c3"
href="mailto:gnomad@broadinstitute.org"
href="/help"
rel="noopener noreferrer"
target="_blank"
>
email
help page
</a>
.
</p>
<p>
Note that, for many reasons (including consent and data usage restrictions), we do not have (and cannot share) phenotype information. Overall, we have limited information that we can share for some cohorts, such as last known age in bins of 5 years (when known) and chromosomal sex.
</p>
<p>
Follow us on Twitter
Expand Down
2 changes: 1 addition & 1 deletion browser/src/robots.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ Allow: /news/changelog/
Allow: /downloads/
Allow: /policies/
Allow: /publications/
Allow: /feedback/
Allow: /contact/
Allow: /help/

0 comments on commit 24835e9

Please sign in to comment.