Skip to content

Commit

Permalink
fix(browser): render fafmax of 0 as - to match pipeline logic
Browse files Browse the repository at this point in the history
  • Loading branch information
rileyhgrant committed Oct 30, 2024
1 parent 383bcfa commit 477a90c
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions browser/src/VariantPage/VariantOccurrenceTable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -109,14 +109,13 @@ const FilteringAlleleFrequency = ({
popmax,
popmax_population: popmaxPopulation,
}: FilteringAlleleFrequencyProps) => {
if (popmax === null) {
// popmax (now called fafmax) of 0 is filtered out of the faf array of candidates
// instead, now display '-' rather than 0 to match the logic in the pipeline
// and in the method team's release process
if (popmax === null || popmax === 0) {
return <span></span>
}

if (popmax === 0) {
return <span>0</span>
}

return (
<span>
{/* @ts-expect-error TS(2322) FIXME: Type '{ children: Element; tooltip: any; }' is not... Remove this comment to see the full error message */}
Expand Down

0 comments on commit 477a90c

Please sign in to comment.