wip(browser): add type to represent gen anc and chromosome

broadinstitute · May 17, 2024 · b323738 · b323738
1 parent 669dee1
commit b323738
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/browser/src/VariantPage/VariantPage.tsx b/browser/src/VariantPage/VariantPage.tsx
@@ -44,7 +44,7 @@ import VariantRelatedVariants from './VariantRelatedVariants'
 import VariantSiteQualityMetrics from './VariantSiteQualityMetrics'
 import VariantTranscriptConsequences from './VariantTranscriptConsequences'
 import { URLBuilder } from '../DatasetSelector'
-import { PopulationId } from '@gnomad/dataset-metadata/gnomadPopulations'
+import { PopulationIdAndChromosome } from '@gnomad/dataset-metadata/gnomadPopulations'
 import { Filter } from '../QCFilter'
 
 const Section = styled.section`
@@ -143,7 +143,7 @@ export type Histogram = {
 }
 
 export type Population = {
-  id: PopulationId
+  id: PopulationIdAndChromosome
   ac: number
   an: number
   ac_hemi: number | null

diff --git a/dataset-metadata/gnomadPopulations.ts b/dataset-metadata/gnomadPopulations.ts
@@ -32,6 +32,8 @@ export const GNOMAD_POPULATION_NAMES = {
 
 export type PopulationId = keyof typeof GNOMAD_POPULATION_NAMES
 
+export type PopulationIdAndChromosome = PopulationId | `${PopulationId}_XX` | `${PopulationId}_XY`
+
 export const populationName = (populationId: string) =>
   textOrMissingTextWarning('genetic ancestry group name', GNOMAD_POPULATION_NAMES, populationId)