Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update order of links on NavBar #1150

Merged
merged 5 commits into from
Aug 10, 2023
Merged

Conversation

iamsadat
Copy link
Contributor

@iamsadat iamsadat commented Aug 6, 2023

Fixes #1149

@mattsolo1
Copy link
Contributor

@rileyhgrant can you please advise @iamsadat on how to get checks to pass?

Copy link
Contributor

@rileyhgrant rileyhgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @iamsadat

Thanks for looking at this! Here are a few comments we'd like you to address:

  1. The convention for naming both Pull Requests and Commits in this Repo is to use present tense, sentence case, and to be descriptive. i.e. the title should be "Update order of links on NavBar" and similarly the commit message should be changed to something like "Update order of links on the NavBar"
  2. We use Jest for testing on the frontend. For many of these simpler components the tests are simple snapshot tests. On your local machine, this should be as simple as running yarn jest --no-cache from the root directory, followed by a yarn jest --no-cache -u <YOUR-TEST-FILE>, in this case something like: yarn jest --no-cache -u NavBar. The -u flag specifies that Jest should update the snapshot generated by the test.
  3. As mentioned in the issue, this will have to be merged in sync with a PR on the gnomAD Blog, since there are two seperate applications. Since I'll be merging this, I can make the other PR.

Thanks again for taking a look at this, this also helps us get our docs in better order (we can do a better job of specifying our conventions, as well as documenting what tests to run locally). Let me know if anything is unclear.

Riley

@iamsadat iamsadat changed the title Updated Navbar Update order of links on NavBar Aug 9, 2023
@iamsadat
Copy link
Contributor Author

iamsadat commented Aug 9, 2023

Hey Riley, Thanks for the help and sorry about the mess I've created. But I've used the naming convention as per the repo. The snapshot has been updated too.
Please let me know if any other changes are required.

@phildarnowsky-broad
Copy link
Contributor

@iamsadat Just wanted to swing by and say thanks for contributing!

@iamsadat
Copy link
Contributor Author

@phildarnowsky-broad
Looking forward to diving even deeper into the project and making a meaningful contributions!

@rileyhgrant rileyhgrant self-requested a review August 10, 2023 21:17
Copy link
Contributor

@rileyhgrant rileyhgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @iamsadat!

I'll merge this PR and squash all the commits into a single one.

Thanks again :)

@rileyhgrant rileyhgrant merged commit a76504c into broadinstitute:main Aug 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-order links on Nav Bar, adjust titles
4 participants