Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject genes on Y chromosome pseudoautosomal region #1204

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

phildarnowsky-broad
Copy link
Contributor

No description provided.

Copy link
Contributor

@mattsolo1 mattsolo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious why this needs a distinct new step for itself? For simplicity would it fit into a prior step?

@phildarnowsky-broad
Copy link
Contributor Author

@mattsolo1 we definitely could put it in an existing step. I seperated it out here to save us some time when we use this shortly to rebuild the data: this way, we can use the old overall output as the input to this new step, rather than back up one or more steps and rebuild from that point on.

However I don't feel very strongly about this point so if you would rather integrate this into an existing step I'm fine with that too.

@phildarnowsky-broad phildarnowsky-broad merged commit e40dad9 into main Oct 27, 2023
1 check passed
@rileyhgrant rileyhgrant deleted the filter_out_par_y branch January 17, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants