Expose non-UK Biobank subset in browser #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
resolves #1448 |
rileyhgrant
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
LGTM!
Looked through commit by commit and only found one tiny thing -- an inconsistency in style of dataset selector name.
Nice on continuing to improve the type system, and on this subset. All the relevant pages (gene, transcript, region, variant) looked good in my local environment to my eyes.
dataset-metadata/metadata.ts
Outdated
| @@ -19,6 +19,7 @@ export const datasetLabels = { | |||
| gnomad_sv_r4: 'gnomAD SVs v4.0', | |||
| gnomad_cnv_r4: 'gnomAD CNVs v4.0', | |||
| gnomad_r4: 'gnomAD v4.0.0', | |||
| gnomad_r4_non_ukb: 'gnomAD 4.1 (non-UKB)', | |||
There was a problem hiding this comment.
Very minor -- based on the others in the list, I think we could add a "v" and maybe make it "4.1.0" , as in "gnomad v4.1.0 (..." just for consistency with the other entries in the list here
| @@ -14,12 +14,14 @@ import largeGenes from '../helpers/large-genes' | |||
|
|
|||
| const GNOMAD_V4_VARIANT_INDEX = 'gnomad_v4_variants' | |||
|
|
|||
| type Subset = 'all' | 'non_ukb' | |||
There was a problem hiding this comment.
Nice on continually improving the types
phildarnowsky-broad
force-pushed
the
non_ukb
branch
from
e92121b
to
ef2857d
Compare
In doing this, most of the existing metadata tests become trivial, so we can get rid of them.
phildarnowsky-broad
force-pushed
the
non_ukb
branch
from
ef2857d
to
c3b20ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we add the non-UK Biobank subset of v4.1 to the dataset selector in the gene, variant, region, and transcript pages.
This also includes a refactoring of the dataset metadata to write out the metadata for each dataset explicitly, rather than having a function per metadata field that takes the dataset name as input--that was proving to be unsustainable. This approach is bulkier but much more straightforward and easier to maintain.