Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update combined frequency flag help page #1502

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Update combined frequency flag help page #1502

merged 3 commits into from
Apr 19, 2024

Conversation

ch-kr
Copy link
Contributor

@ch-kr ch-kr commented Apr 19, 2024

  • Added note that this is MVP version
  • Added screenshots
    I decided not to copy and paste the reasons from the blog post, but let me know if you feel that makes sense

@ch-kr ch-kr requested a review from jkgoodrich April 19, 2024 16:33
Copy link
Contributor

@jkgoodrich jkgoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few thoughts and requested changes

browser/help/topics/combined-freq-stats.md Outdated Show resolved Hide resolved
browser/help/topics/combined-freq-stats.md Outdated Show resolved Hide resolved
browser/help/topics/combined-freq-stats.md Outdated Show resolved Hide resolved
@ch-kr ch-kr requested a review from jkgoodrich April 19, 2024 18:17
Copy link
Contributor

@jkgoodrich jkgoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs the hover png's added

Copy link
Contributor

@jkgoodrich jkgoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rileyhgrant rileyhgrant merged commit 2227a8c into main Apr 19, 2024
1 check passed
@rileyhgrant rileyhgrant deleted the joint_freq_flag branch April 19, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants