ci: add PHP 8.3 to workflow matrix

brotkrueml · Jan 16, 2024 · e6085af · e6085af
1 parent df4ceee
commit e6085af
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 5 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -32,6 +32,10 @@ jobs:
             typo3-versions: ^11
           - php-versions: 8.2
             typo3-versions: ^12
+          - php-versions: 8.3
+            typo3-versions: ^11
+          - php-versions: 8.3
+            typo3-versions: ^12
     steps:
       - name: Check out repository
         uses: actions/checkout@v3

diff --git a/Classes/Guards/IntervalGuard.php b/Classes/Guards/IntervalGuard.php
@@ -30,6 +30,8 @@ public function guard($interval): string
         }
 
         if (@\DateInterval::createFromDateString($interval) === false) {
+            // @todo Remove check and exception when compatibility of PHP >= 8.3
+            // @see https://www.php.net/manual/de/class.datemalformedintervalstringexception.php
             throw new \InvalidArgumentException(
                 \sprintf(
                     'Interval is not valid, "%s" given!',

diff --git a/Tests/Unit/Guards/IntervalGuardTest.php b/Tests/Unit/Guards/IntervalGuardTest.php
@@ -55,12 +55,25 @@ public function providerForInvalidIntervals(): iterable
             'expectedMessage' => 'Interval must be a string!',
             'expectedCode' => 1671448703,
         ];
+    }
 
-        yield 'interval is an invalid string' => [
-            'interval' => 'This is invalid',
-            'expectedMessage' => 'Interval is not valid, "This is invalid" given!',
-            'expectedCode' => 1671448704,
-        ];
+    /**
+     * @test
+     *
+     * @todo Remove when compatibility of PHP >= 8.3
+     * @see https://www.php.net/manual/de/class.datemalformedintervalstringexception.php
+     */
+    public function guardThrowsExceptionOnInvalidIntervalWhenCreating(): void
+    {
+        if (\version_compare(\PHP_VERSION, '8.3.0', '>=')) {
+            self::markTestSkipped();
+        }
+
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('Interval is not valid, "This is invalid" given!');
+        $this->expectExceptionCode(1671448704);
+
+        $this->subject->guard('This is invalid');
     }
 
     /**